Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch log function name in gptq #168

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Patch log function name in gptq #168

merged 3 commits into from
Sep 13, 2024

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Revert logging changes introduced by GPTQ Algorithm Cleanup #120
  • Make log messages nicer by changing the name of the function that is calling them

Before

2024-09-12T03:12:20.499337+0000 | compress_module | INFO - Compressing model.layers.23.model.layers.23.mlp.down_proj...
2024-09-12T03:12:22.485596+0000 | _log_metrics | METRIC - time 1.99
2024-09-12T03:12:22.486285+0000 | _log_metrics | METRIC - error 312.77
2024-09-12T03:12:22.486857+0000 | _log_metrics | METRIC - GPU 0 | usage: 7.72% | total memory: 15 GB
2024-09-12T03:12:22.486891+0000 | _log_metrics | METRIC - GPU 1 | usage: 8.17% | total memory: 15 GB
2024-09-12T03:12:22.486945+0000 | _log_metrics | METRIC - Compressed layer size: 8.428466796875 MB

After

2024-09-12T03:22:18.627134+0000 | compress_module | INFO - Compressing model.layers.23.model.layers.23.mlp.down_proj...
2024-09-12T03:22:20.484464+0000 | compress | METRIC - time 1.86
2024-09-12T03:22:20.485176+0000 | compress | METRIC - error 312.77
2024-09-12T03:22:20.485331+0000 | compress | METRIC - GPU 0 | usage: 7.72% | total memory: 15 GB
2024-09-12T03:22:20.485368+0000 | compress | METRIC - GPU 1 | usage: 8.17% | total memory: 15 GB
2024-09-12T03:22:20.485426+0000 | compress | METRIC - Compressed layer size: 8.428466796875 MB

Changes

  • Used logaru patching to change function name in logs

Testing

  • gptq compression was run to completion

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@kylesayrs kylesayrs changed the title patch log function name Patch log function name in gptq Sep 12, 2024
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending quality fix failures.

@dsikka dsikka merged commit e044902 into main Sep 13, 2024
6 of 7 checks passed
@dsikka dsikka deleted the kylesayrs/patch-logaru-gptq branch September 13, 2024 17:27
markmc pushed a commit to markmc/llm-compressor that referenced this pull request Nov 13, 2024
Co-authored-by: Kyle Sayers <kyle@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants