[Bug] Fix validation errors for smoothquant modifier + update examples #19
+16
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug, where SmoothQuant modifier wasn't being passed in correctly due to validation errors, this PR fixes that
Why?
The typing of one of the attributes from SmoothQuant Modifier was misleading
Scope?
This only affected cases where smoothquant modifer was passed in as an instantiated object, (cases where it is defined in a string or as a yaml recipe remain unaffected)
Test plan?
Ran the
w8a8_int8
example successfully onXenova/llama2.c-stories15M