Disable Default Bitmask Compression #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This issue came up a few days ago where a user tried to run a sparsified model in vLLM: #45. We compress sparse models into the "sparse-bitmask" compression format by default on save, however this format isn't yet supported in vLLM. I'm updating the save logic to disable automatic sparse compression for now, we can re-enable once this is supported in vLLM
TEST PLAN:
Manual test to confirm sparse models are saved as dense by default:
Output
config.json
shows the expected dense format: