Skip to content

Conversation

@philandstuff
Copy link
Contributor

@philandstuff philandstuff commented Sep 3, 2025

Quite a few chart features have landed since the last version: https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from #568.


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

Quite a few chart features have landed since the last version:
https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from vllm-project#568.

Signed-off-by: Philip Potter <philip.g.potter@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @philandstuff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Helm chart version to incorporate several new features and improvements that have been merged into the main branch since the last release. This ensures users can leverage the latest functionalities, such as autoscaling, by simply updating their chart dependency.

Highlights

  • Helm Chart Version Update: The vllm-production-stack Helm chart version has been incremented from 0.1.6 to 0.1.7.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the Helm chart version from 0.1.6 to 0.1.7. As noted in the pull request description, this release includes new features. According to Semantic Versioning, adding new, backward-compatible functionality should be a minor version bump. Therefore, I've suggested changing the version to 0.2.0.

# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.6
version: 0.1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Given that this release includes new features (such as autoscaling, as mentioned in the PR description), it would be more appropriate to increment the minor version to 0.2.0 instead of making a patch release. This aligns with the Semantic Versioning (SemVer) guidelines mentioned in the comments of this file, where new, backward-compatible functionality warrants a minor version increase.1

version: 0.2.0

Style Guide References

Footnotes

  1. The comments in this file (lines 15-17) state that versions should follow Semantic Versioning. SemVer specifies that MINOR version bumps are for when you add functionality in a backwards-compatible manner, while PATCH versions are for backwards-compatible bug fixes.

Copy link
Collaborator

@YuhanLiu11 YuhanLiu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YuhanLiu11 YuhanLiu11 merged commit b6dd717 into vllm-project:main Sep 3, 2025
10 checks passed
@philandstuff philandstuff deleted the bump-helm-chart-version branch September 4, 2025 08:16
Senne-Mennes pushed a commit to Senne-Mennes/production-stack that referenced this pull request Oct 22, 2025
Quite a few chart features have landed since the last version:
https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from vllm-project#568.

Signed-off-by: Philip Potter <philip.g.potter@gmail.com>
Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
sebastiaanvduijn pushed a commit to sebastiaanvduijn/vllm-production-stack that referenced this pull request Nov 13, 2025
Quite a few chart features have landed since the last version:
https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from vllm-project#568.

Signed-off-by: Philip Potter <philip.g.potter@gmail.com>
Signed-off-by: Sebastiaan van Duijn <sebastiaan.vanduijn@triviumpackaging.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants