[TPU host offoad] fix pin/unpin cpu backend keys logic #1025
+121
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start with a short description of what the PR does and how this is a change from
the past.
This commit addresses a race condition in the CPU KV cache where a cached block could be prematurely evicted if multiple requests were relying on it and one of the requests finished early.
The rest of the description includes relevant details and context, examples:
The LocalCPUBackend now uses a reference counting mechanism for pinned keys:
Replaced the pinned_keys set with a
pin_countsdictionary to track active references for each cached block.The contains method increments the reference count when a key is pinned.
The maybe_unpin_keys method decrements the count and only truly unpins a key when its reference count reaches zero.
The eviction logic in the add() method now respects these reference counts preventing eviction of actively used blocks.
Additionally, the unpin_keys method was renamed to maybe_unpin_keys to better reflect its conditional nature.
shortcomings of the solution and possible future improvements.
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure: