Skip to content

Conversation

@Yikun
Copy link
Collaborator

@Yikun Yikun commented Jun 7, 2025

What this PR does / why we need it?

  1. The dependency was introduced by Spec decode support for V1 Engine #874
  • Move numba/quart from requirements-dev to requirments
  • Align pyproject.toml with requirements
  1. This patch also fix deepseek accuracy baseline which [bugfix] fix deeepseek accuracy #1118 was not addressed. According to https://huggingface.co/deepseek-ai/DeepSeek-V2-Lite the gsm8k is about 41.1

  2. This also sync the vLLM upstream changes: vllm-project/vllm@eaa2e51

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed
vllm ascend test (basic workflow)
vllm longterm test (spec decode)

Closes: #1120

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun added ready read for review long-term-test enable long term test for PR ready-for-test start test by label for PR pd-test enable pd test for PR labels Jun 7, 2025
@Yikun
Copy link
Collaborator Author

Yikun commented Jun 8, 2025

It's ready when all CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun changed the title [Build] Move numba/quart from requirements-dev to requirments [Build] Move numba/quart from dev to requirments and update DeepSeek test baseline Jun 8, 2025
@Yikun Yikun added ready-for-test start test by label for PR and removed ready-for-test start test by label for PR labels Jun 8, 2025
@Yikun Yikun changed the title [Build] Move numba/quart from dev to requirments and update DeepSeek test baseline [Build] Move numba/quart to requirments and update DS baseline and sync graph typo fix Jun 8, 2025
@Yikun Yikun added ready-for-test start test by label for PR and removed pd-test enable pd test for PR ready-for-test start test by label for PR labels Jun 8, 2025
entry.aclgraph = aclgraph

compilation_counter.num_cudagraph_caputured += 1
compilation_counter.num_cudagraph_captured += 1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 0.9.0...

num_piecewise_capturable_graphs_seen=3, # 1 + num_layers
num_backend_compilations=3, # num_piecewise_capturable_graphs_seen
num_cudagraph_caputured=
num_cudagraph_captured=
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 0.9.0

@Yikun Yikun force-pushed the fix-numba branch 2 times, most recently from c786501 to a18d381 Compare June 8, 2025 12:02
@Yikun Yikun removed the ready-for-test start test by label for PR label Jun 8, 2025
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun added the ready-for-test start test by label for PR label Jun 8, 2025
@Yikun Yikun marked this pull request as ready for review June 8, 2025 14:33
@Yikun Yikun merged commit 4976b48 into vllm-project:main Jun 8, 2025
30 checks passed
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
…nc graph typo fix (vllm-project#1121)

### What this PR does / why we need it?
1. The dependency was introduced by
vllm-project#874
- Move numba/quart from requirements-dev to requirments
- Align pyproject.toml with requirements

2. This patch also fix deepseek accuracy baseline which
vllm-project#1118 was not addressed.
According to https://huggingface.co/deepseek-ai/DeepSeek-V2-Lite the
gsm8k is about `41.1`

3. This also sync the vLLM upstream changes:
vllm-project/vllm@eaa2e51

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed
vllm ascend test (basic workflow)
vllm longterm test (spec decode)

Closes: vllm-project#1120

---------

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…nc graph typo fix (vllm-project#1121)

### What this PR does / why we need it?
1. The dependency was introduced by
vllm-project#874
- Move numba/quart from requirements-dev to requirments
- Align pyproject.toml with requirements

2. This patch also fix deepseek accuracy baseline which
vllm-project#1118 was not addressed.
According to https://huggingface.co/deepseek-ai/DeepSeek-V2-Lite the
gsm8k is about `41.1`

3. This also sync the vLLM upstream changes:
vllm-project/vllm@eaa2e51

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed
vllm ascend test (basic workflow)
vllm longterm test (spec decode)

Closes: vllm-project#1120

---------

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

long-term-test enable long term test for PR module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Main][Bug]: Failed to start server with V1 enable due to No module named 'numba'

2 participants