[fix] fix bug in 1p1d disaggregated_prefill example #1153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What this PR does / why we need it? fix bug in 1p1d disaggregated_prefill example ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with python find_device_ips.py and run disaggregated_prefill example Signed-off-by: wangyanhui <1027866388@qq.com>
### What this PR does / why we need it? fix bug in 1p1d disaggregated_prefill example ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with python find_device_ips.py and run disaggregated_prefill example Signed-off-by: wangyanhui <1027866388@qq.com>
wangxiyuan
approved these changes
Jun 10, 2025
|
Hi, I want to know the current disaggregated prefill is just for vllm v0 version or it can work in v1 version? |
just for v0，v1 is in developing |
|
@ChenTaoyu-SJTU V1 support is WIP #950 |
|
When will this PR be merged? |
wangxiyuan
reviewed
Jun 12, 2025
| re.match(r".*\n\t([0-9]+).*", | ||
| npu_info.stdout).group(1)) # type: ignore | ||
|
|
||
| # 提取所有 Ascend 设备的 NPU ID（排除 Mcu 行） |
There was a problem hiding this comment.
please rewrite to english
There was a problem hiding this comment.
because my email changed,I will close this PR and create a new: #1184 check and merge it,thank you very much.
### What this PR does / why we need it? fix bug in 1p1d disaggregated_prefill example ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with python find_device_ips.py and run disaggregated_prefill example Signed-off-by: wangyanhui <1027866388@qq.com>
### What this PR does / why we need it? fix bug in 1p1d disaggregated_prefill example ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with python find_device_ips.py and run disaggregated_prefill example Signed-off-by: wangyanhui <1027866388@qq.com>
### What this PR does / why we need it? fix bug in 1p1d disaggregated_prefill example ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with python find_device_ips.py and run disaggregated_prefill example Signed-off-by: wangyanhui <1027866388@qq.com>
### What this PR does / why we need it? fix bug in 1p1d disaggregated_prefill example ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with python find_device_ips.py and run disaggregated_prefill example Signed-off-by: wangyanhui <1027866388@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
fix bug in 1p1d disaggregated_prefill example
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested with python find_device_ips.py and run disaggregated_prefill example