Skip to content

Conversation

@Yikun
Copy link
Collaborator

@Yikun Yikun commented Jun 12, 2025

What this PR does / why we need it?

Recover scheduler test

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Closes: #1180

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun
Copy link
Collaborator Author

Yikun commented Jun 12, 2025

tests/singlecard/compile/test_simple.py::test_simple_piecewise_compile SKIPPED
tests/singlecard/core/test_ascend_scheduler.py::test_add_requests PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_finish_request PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_get_num_unfinished_requests PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule[None-None] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule[True-5] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_concurrent_partial_requests[True] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_concurrent_partial_requests[False] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_stop_via_update_from_output PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_concurrent_batches[None-None] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_concurrent_batches[True-5] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_spec_decoding_stats[spec_tokens0-output_tokens0-expected0] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_spec_decoding_stats[spec_tokens1-output_tokens1-expected1] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_spec_decoding_stats[spec_tokens2-output_tokens2-expected2] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_spec_decoding_stats[spec_tokens3-output_tokens3-expected3] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_spec_decoding_stats[spec_tokens4-output_tokens4-expected4] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_schedule_spec_decoding_stats[spec_tokens5-output_tokens5-expected5] PASSED
tests/singlecard/core/test_ascend_scheduler.py::test_memory_leak PASSED

https://github.com/vllm-project/vllm-ascend/actions/runs/15603776668/job/43948771826?pr=1185#step:10:359

@Yikun Yikun marked this pull request as ready for review June 12, 2025 08:40
@Yikun
Copy link
Collaborator Author

Yikun commented Jun 12, 2025

@whx-sjtu @wangxiyuan @ganyi1996ppo I suggest merge this

--ignore=tests/singlecard/test_ascend_config.py \
--ignore=tests/singlecard/test_prompt_embedding.py \
--ignore=tests/singlecard/core/test_ascend_scheduler.py \
--ignore=tests/singlecard/core/test_ascend_scheduler_e2e.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to run ut for AscendScheduler in ci of v0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested to keep same logic in workflow and we already skip v1 in test case, so I think it's OK, WDYT?

@Yikun Yikun closed this Jun 12, 2025
@Yikun
Copy link
Collaborator Author

Yikun commented Jun 12, 2025

I already merge the original PR, we will squash into one in separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants