[Fix] Revert 20dedb to fix ACL Graph #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@ganyi1996ppo @momo609 please review |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ted when inferencing Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
…oject#736)" This reverts commit 20dedba. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
…as expected when inferencing" This reverts commit 36519ff. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Collaborator
|
This is a revert PR + ut case right? looks good |
yiz-liu
changed the title
ganyi1996ppo
approved these changes
Jun 16, 2025
Collaborator
|
@ChenTaoyu-SJTU Please also take look on this . @yiz-liu I remember this PR added a e2e test to help reproduce the aclgraph test why it be removed? This is very helpfully to help taoyu re-add this feature with aclgraph e2e test pass |
Yikun
requested changes
Jun 16, 2025
Collaborator
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
@yiz-liu I'm OK with revert it, but please update the commit msg to be more neutral and please do not include any blame. This is a community, if you find a problem, fix it. Especially for the code that has been merged, everyone has the obligation to help fix it.
Yikun
approved these changes
Jun 16, 2025
Collaborator
|
Thanks |
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 17, 2025
### What this PR does / why we need it? This PR revert 20dedb to restore the tokenwise padding logics so that ACL Graph can work as expected. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
yiz-liu
added a commit
to yiz-liu/vllm-ascend
that referenced
this pull request
Jun 17, 2025
This reverts commit 73979f5. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
yiz-liu
added a commit
to yiz-liu/vllm-ascend
that referenced
this pull request
Jun 17, 2025
### What this PR does / why we need it? This PR revert 20dedb to restore the tokenwise padding logics so that ACL Graph can work as expected. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
yiz-liu
added a commit
to yiz-liu/vllm-ascend
that referenced
this pull request
Jun 17, 2025
This reverts commit 73979f5. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
yiz-liu
added a commit
to yiz-liu/vllm-ascend
that referenced
this pull request
Jun 17, 2025
This reverts commit 73979f5. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR revert 20dedb to restore the tokenwise padding logics so that ACL Graph can work as expected.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed