[Build] Speedup image build #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangxiyuan Do you think it's a acceptable improvement? speed by droping e2e and build on arm64 / amd64 separately. After this PR, time reduced then we can have time and chance to add a e2e image test per PR in future. |
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
wangxiyuan
approved these changes
Jun 16, 2025
|
after this PR:
Some edge case is not covered, like build amd64 on openEuler. But I think it's fine. Let' merge this first. If we hit any problem later, we can revert it. |
shiyuan680
pushed a commit
to raindaywhu/vllm-ascend
that referenced
this pull request
Jul 7, 2025
### What this PR does / why we need it? 1. Rename workflow name to show OS info 2. Speedup image build: - PR: only arm64 build on openEuler arm64, only amd64 build on Ubuntu amd64 - Push/Tag: still keep origin logic use qemu on amd64 This PR actually drop the e2e image build per PR but I think it's fine consider it's stable enough, if we still meet some problem we can revert this PR 43-44mins ---> about 8-10 mins ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
### What this PR does / why we need it? 1. Rename workflow name to show OS info 2. Speedup image build: - PR: only arm64 build on openEuler arm64, only amd64 build on Ubuntu amd64 - Push/Tag: still keep origin logic use qemu on amd64 This PR actually drop the e2e image build per PR but I think it's fine consider it's stable enough, if we still meet some problem we can revert this PR 43-44mins ---> about 8-10 mins ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? 1. Rename workflow name to show OS info 2. Speedup image build: - PR: only arm64 build on openEuler arm64, only amd64 build on Ubuntu amd64 - Push/Tag: still keep origin logic use qemu on amd64 This PR actually drop the e2e image build per PR but I think it's fine consider it's stable enough, if we still meet some problem we can revert this PR 43-44mins ---> about 8-10 mins ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR actually drop the e2e image build per PR but I think it's fine consider it's stable enough, if we still meet some problem we can revert this PR
43-44mins ---> about 8-10 mins
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed