[e2e]Fixed the issue that pyhccl e2e cannot run continuously with other tests #1246
+54
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ji-huazhong Could you help review this PR? Content: "Open pyhccl distributed test case" |
I have discussed this with Ji Huazhong and he thinks this is okay. @Yikun It is ready to review and merge. |
Yikun
reviewed
Jun 18, 2025
…tests. 2.Cleaned up the resources occupied by the dynamic_npugraph_batchsize e2e test. Signed-off-by: leo-pony <nengjunma@outlook.com>
leo-pony
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 60.61% 60.61%
=======================================
Files 75 75
Lines 8127 8127
=======================================
Hits 4926 4926
Misses 3201 3201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leo-pony
changed the title
|
@Yikun This PR is ready, Plz help review. |
wangxiyuan
approved these changes
Jul 29, 2025
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jul 30, 2025
…er tests (vllm-project#1246) ### What this PR does / why we need it? 1.Fixed the issue that pyhccl e2e cannot run continuously with other tests. 2.Cleaned up the resources occupied by the dynamic_npugraph_batchsize e2e test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is a e2e test e2e multi-cards tests local running successfully. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@0df4d9b Signed-off-by: leo-pony <nengjunma@outlook.com>
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jul 30, 2025
…er tests (vllm-project#1246) ### What this PR does / why we need it? 1.Fixed the issue that pyhccl e2e cannot run continuously with other tests. 2.Cleaned up the resources occupied by the dynamic_npugraph_batchsize e2e test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is a e2e test e2e multi-cards tests local running successfully. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@0df4d9b Signed-off-by: leo-pony <nengjunma@outlook.com> Signed-off-by: weijinqian_v1 <weijinqian@huawei.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
…er tests (vllm-project#1246) ### What this PR does / why we need it? 1.Fixed the issue that pyhccl e2e cannot run continuously with other tests. 2.Cleaned up the resources occupied by the dynamic_npugraph_batchsize e2e test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is a e2e test e2e multi-cards tests local running successfully. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@0df4d9b Signed-off-by: leo-pony <nengjunma@outlook.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
…er tests (vllm-project#1246) ### What this PR does / why we need it? 1.Fixed the issue that pyhccl e2e cannot run continuously with other tests. 2.Cleaned up the resources occupied by the dynamic_npugraph_batchsize e2e test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is a e2e test e2e multi-cards tests local running successfully. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@0df4d9b Signed-off-by: leo-pony <nengjunma@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
1.Fixed the issue that pyhccl e2e cannot run continuously with other tests.
2.Cleaned up the resources occupied by the dynamic_npugraph_batchsize e2e test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This is a e2e test
e2e multi-cards tests local running successfully.