Skip to content

Conversation

@paulyu12
Copy link
Collaborator

What this PR does / why we need it?

Add LoRA user guide to DOC. The content refers to LoRA Adapters.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

Signed-off-by: paulyu12 <507435917@qq.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 17, 2025
paulyu12 added 2 commits June 17, 2025 20:44
Signed-off-by: paulyu12 <507435917@qq.com>
Signed-off-by: paulyu12 <507435917@qq.com>
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@paulyu12 paulyu12 requested a review from wangxiyuan June 23, 2025 01:40
@wangxiyuan wangxiyuan mentioned this pull request Jun 25, 2025
40 tasks
@wangxiyuan
Copy link
Collaborator

@paulyu12 Hi, thanks for the doc. I notice that most content is from vLLM doc. I think in vLLM Ascend doc, we don't need to re-write them again. For the most common part, we can add the link to vLLM directly. What we should write more is: what's the different usage on vLLM Ascend, for example, any model support list or limitation? Any feature + feature limitation? 2. How users use this feature with vLLM Ascend and so on.

@paulyu12
Copy link
Collaborator Author

Actually, users can use LoRA with the user guide of vLLM doc. No extra limitation as I know. Because aclgraph mode doesn't support LoRA until now, maybe I'll add some tips about how to fallback to non-aclgraph mode.

@paulyu12
Copy link
Collaborator Author

And the models that LoRA supports can be referred by vLLM Supported Models

image

@wangxiyuan
Copy link
Collaborator

So the doc can be simple in vllm-ascend. Just add something like:

vLLM Ascend support lora the same as vLLM. More detail can be found in vLLM official document.

Then add some limitation, like: does lora in vllm-ascend support graph mode? what model has been tested and so on.

Signed-off-by: paulyu12 <507435917@qq.com>
@wangxiyuan wangxiyuan merged commit c3c8c93 into vllm-project:main Jul 2, 2025
5 checks passed
ZhengWG pushed a commit to ZhengWG/vllm-ascend that referenced this pull request Jul 3, 2025
### What this PR does / why we need it?
Add LoRA user guide to DOC. The content refers to [LoRA
Adapters](https://docs.vllm.ai/en/latest/features/lora.html).

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
No

---------

Signed-off-by: paulyu12 <507435917@qq.com>
Signed-off-by: ZhengWG <zwg0606@gmail.com>
ZhengWG pushed a commit to ZhengWG/vllm-ascend that referenced this pull request Jul 3, 2025
### What this PR does / why we need it?
Add LoRA user guide to DOC. The content refers to [LoRA
Adapters](https://docs.vllm.ai/en/latest/features/lora.html).

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
No

---------

Signed-off-by: paulyu12 <507435917@qq.com>
Signed-off-by: ZhengWG <zwg0606@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
### What this PR does / why we need it?
Add LoRA user guide to DOC. The content refers to [LoRA
Adapters](https://docs.vllm.ai/en/latest/features/lora.html).

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
No

---------

Signed-off-by: paulyu12 <507435917@qq.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Add LoRA user guide to DOC. The content refers to [LoRA
Adapters](https://docs.vllm.ai/en/latest/features/lora.html).

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
No

---------

Signed-off-by: paulyu12 <507435917@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants