[BugFix] fix length of sin/cos cache in rope #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: whx-sjtu <2952154980@qq.com>
wangxiyuan
approved these changes
Jun 17, 2025
|
Please update the test as well or later |
ganyi1996ppo
approved these changes
Jun 17, 2025
Yikun
added a commit
to Yikun/vllm-ascend
that referenced
this pull request
Jun 21, 2025
…)" This reverts commit d7e19ed.
Yikun
added a commit
to Yikun/vllm-ascend
that referenced
this pull request
Jun 21, 2025
…)" This reverts commit d7e19ed.
shiyuan680
pushed a commit
to raindaywhu/vllm-ascend
that referenced
this pull request
Jul 7, 2025
This PR fixes the bug that constructs shorter sin/cos cache than model's max positional embedding. Closes: vllm-project#1038 Signed-off-by: whx-sjtu <2952154980@qq.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
This PR fixes the bug that constructs shorter sin/cos cache than model's max positional embedding. Closes: vllm-project#1038 Signed-off-by: whx-sjtu <2952154980@qq.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
This PR fixes the bug that constructs shorter sin/cos cache than model's max positional embedding. Closes: vllm-project#1038 Signed-off-by: whx-sjtu <2952154980@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that constructs shorter sin/cos cache than model's max positional embedding.
Closes: #1038