Skip to content

Conversation

@wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jun 19, 2025

refactor test_expert_load_balancer to keep the ut code style

This PR also fixed the break change from https://github.com/vllm-project/vllm/pull/16188/files#diff-e2942ece30a5c580437694ffb964bfc664b510c59244c08e5921b8f5cefb4280

This is just a quick fix. We'll support embedding on V1 later

Closes: #1299

@wangxiyuan wangxiyuan force-pushed the refactor_ut branch 3 times, most recently from 04c5f69 to 9fb925b Compare June 19, 2025 06:20
@wangxiyuan wangxiyuan changed the title [UT] refactor test_expert_load_balancer [UT] refactor test_expert_load_balancer and fix broken CI Jun 19, 2025
@wangxiyuan wangxiyuan force-pushed the refactor_ut branch 5 times, most recently from 0e2da4c to b40042f Compare June 19, 2025 14:24
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@Yikun
Copy link
Collaborator

Yikun commented Jun 19, 2025

Merge this to recover CI

cc @ganyi1996ppo @jianzs

@Yikun Yikun merged commit b350eda into vllm-project:main Jun 19, 2025
20 checks passed
@wangxiyuan wangxiyuan deleted the refactor_ut branch June 27, 2025 01:17
shiyuan680 pushed a commit to raindaywhu/vllm-ascend that referenced this pull request Jul 7, 2025
…ct#1293)

refactor test_expert_load_balancer to keep the ut code style

This PR also fixed the break change from
https://github.com/vllm-project/vllm/pull/16188/files#diff-e2942ece30a5c580437694ffb964bfc664b510c59244c08e5921b8f5cefb4280

This is just a quick fix. We'll support embedding on V1 later

Closes: vllm-project#1299

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
…ct#1293)

refactor test_expert_load_balancer to keep the ut code style

This PR also fixed the break change from
https://github.com/vllm-project/vllm/pull/16188/files#diff-e2942ece30a5c580437694ffb964bfc664b510c59244c08e5921b8f5cefb4280

This is just a quick fix. We'll support embedding on V1 later

Closes: vllm-project#1299

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…ct#1293)

refactor test_expert_load_balancer to keep the ut code style

This PR also fixed the break change from
https://github.com/vllm-project/vllm/pull/16188/files#diff-e2942ece30a5c580437694ffb964bfc664b510c59244c08e5921b8f5cefb4280

This is just a quick fix. We'll support embedding on V1 later

Closes: vllm-project#1299

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attribute issue for latest upstream vllm, Need pull request

2 participants