[perf] optimize rope in deepseek #1304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Same with #993 ? |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
whx-sjtu
reviewed
Jul 3, 2025
vllm_ascend/models/deepseek_v2.py
Outdated
|
|
||
| replace_allreduce = hidden_states.shape[0] % self.tp_size == 0 | ||
| # get cos, sin before layers | ||
| self.running_in_graph = self.torchair_graph_enabled and attn_metadata.attn_state in [ |
Collaborator
There was a problem hiding this comment.
attn_metadata is none in warmup phase
github-actions
bot
added
documentation
Signed-off-by: David9857 <985700846@qq.com>
github-actions
bot
removed
documentation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Collaborator
|
no update for long time. Close it now. Feel free to create a new one if it's still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?