Skip to content

Conversation

@MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Jun 24, 2025

What this PR does / why we need it?

Make external DP support on EP and ETP
fix #1396 #1154

How was this patch tested?

CI passed with new added test.

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.23%. Comparing base (c30ddb8) to head (602e688).
⚠️ Report is 644 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/distributed/parallel_state.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
- Coverage   27.39%   27.23%   -0.16%     
==========================================
  Files          56       56              
  Lines        6191     6209      +18     
==========================================
- Hits         1696     1691       -5     
- Misses       4495     4518      +23     
Flag Coverage Δ
unittests 27.23% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
@MengqingCao MengqingCao marked this pull request as ready for review June 25, 2025 02:57
@MengqingCao MengqingCao changed the title [WIP][ExternalDP][RL] Make external DP support on EP and ETP [ExternalDP][RL] Make external DP support on EP and ETP Jun 25, 2025
@MengqingCao
Copy link
Collaborator Author

This is ready for review @Yikun @wangxiyuan @ganyi1996ppo

@MengqingCao
Copy link
Collaborator Author

Will close after #1422 is backportted on main

@MengqingCao
Copy link
Collaborator Author

closing as done in #1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: assert self.cpu_group is not None

1 participant