[BugFix]Remove not using patch_eagle.py for CI. #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuancaoyaoHW
force-pushed
the
remove-patch
branch
from
6deae75 to
6ee0615
Compare
|
nice change, approve |
mengwei805
approved these changes
Jun 24, 2025
mengwei805
added
long-term-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 27.39% 27.25% -0.14%
==========================================
Files 56 55 -1
Lines 6191 6186 -5
==========================================
- Hits 1696 1686 -10
- Misses 4495 4500 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
approved these changes
Jun 24, 2025
yuancaoyaoHW
force-pushed
the
remove-patch
branch
from
6ee0615 to
0bb3ac1
Compare
yuancaoyaoHW
changed the title
mengwei805
added
ready
|
this pr need not run long term CI |
yuancaoyaoHW
force-pushed
the
remove-patch
branch
3 times, most recently
from
50f1ddf to
874bd3d
Compare
Yikun
added
long-term-test
yuancaoyaoHW
force-pushed
the
remove-patch
branch
2 times, most recently
from
6898fd4 to
d065bdf
Compare
Yikun
added
ready-for-test
yuancaoyaoHW
force-pushed
the
remove-patch
branch
from
d065bdf to
85afcf3
Compare
Signed-off-by: yuancaoyaoHW <a2749322671@gmail.com>
yuancaoyaoHW
force-pushed
the
remove-patch
branch
from
85afcf3 to
de5be4e
Compare
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jun 30, 2025
### What this PR does / why we need it? This PR aims to address a long-standing **CI bug** and remove unused code. The specific changes include: 1. **Fixing CI Bug**: Resolves the root cause of CI test failures or instability. This often stems from incorrect environment configurations, dependency version conflicts, or flawed test script logic. This fix ensures the reliability and consistency of the CI pipeline. 2. **Removing `patch_eagle.py`**: Deletes the `patch_eagle.py` file, which is no longer utilized by the project. This file was likely legacy code, experimental code, or its functionality has since been replaced by other modules. Its removal helps reduce codebase complexity, improves maintainability, and prevents potential confusion. ### Does this PR introduce _any_ user-facing change? No, this PR primarily focuses on internal CI stability maintenance and code cleanup. It does not introduce any user-visible changes to APIs, interfaces, or other behaviors. ### How was this patch tested? CI passed. Specifically: 1. **Existing CI Pipelines Passed**: After fixing the CI bug, all existing CI tests and pipelines were verified to run correctly and pass successfully. 2. **Code Cleanup Verified**: Following the removal of `patch_eagle.py`, it was ensured that any related functional modules (if applicable) continue to work as expected, without introducing new regressions. This was typically verified by running the project's main test suite. Signed-off-by: yuancaoyaoHW <a2749322671@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
### What this PR does / why we need it? This PR aims to address a long-standing **CI bug** and remove unused code. The specific changes include: 1. **Fixing CI Bug**: Resolves the root cause of CI test failures or instability. This often stems from incorrect environment configurations, dependency version conflicts, or flawed test script logic. This fix ensures the reliability and consistency of the CI pipeline. 2. **Removing `patch_eagle.py`**: Deletes the `patch_eagle.py` file, which is no longer utilized by the project. This file was likely legacy code, experimental code, or its functionality has since been replaced by other modules. Its removal helps reduce codebase complexity, improves maintainability, and prevents potential confusion. ### Does this PR introduce _any_ user-facing change? No, this PR primarily focuses on internal CI stability maintenance and code cleanup. It does not introduce any user-visible changes to APIs, interfaces, or other behaviors. ### How was this patch tested? CI passed. Specifically: 1. **Existing CI Pipelines Passed**: After fixing the CI bug, all existing CI tests and pipelines were verified to run correctly and pass successfully. 2. **Code Cleanup Verified**: Following the removal of `patch_eagle.py`, it was ensured that any related functional modules (if applicable) continue to work as expected, without introducing new regressions. This was typically verified by running the project's main test suite. Signed-off-by: yuancaoyaoHW <a2749322671@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? This PR aims to address a long-standing **CI bug** and remove unused code. The specific changes include: 1. **Fixing CI Bug**: Resolves the root cause of CI test failures or instability. This often stems from incorrect environment configurations, dependency version conflicts, or flawed test script logic. This fix ensures the reliability and consistency of the CI pipeline. 2. **Removing `patch_eagle.py`**: Deletes the `patch_eagle.py` file, which is no longer utilized by the project. This file was likely legacy code, experimental code, or its functionality has since been replaced by other modules. Its removal helps reduce codebase complexity, improves maintainability, and prevents potential confusion. ### Does this PR introduce _any_ user-facing change? No, this PR primarily focuses on internal CI stability maintenance and code cleanup. It does not introduce any user-visible changes to APIs, interfaces, or other behaviors. ### How was this patch tested? CI passed. Specifically: 1. **Existing CI Pipelines Passed**: After fixing the CI bug, all existing CI tests and pipelines were verified to run correctly and pass successfully. 2. **Code Cleanup Verified**: Following the removal of `patch_eagle.py`, it was ensured that any related functional modules (if applicable) continue to work as expected, without introducing new regressions. This was typically verified by running the project's main test suite. Signed-off-by: yuancaoyaoHW <a2749322671@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR aims to address a long-standing CI bug and remove unused code. The specific changes include:
patch_eagle.py: Deletes thepatch_eagle.pyfile, which is no longer utilized by the project. This file was likely legacy code, experimental code, or its functionality has since been replaced by other modules. Its removal helps reduce codebase complexity, improves maintainability, and prevents potential confusion.Does this PR introduce any user-facing change?
No, this PR primarily focuses on internal CI stability maintenance and code cleanup. It does not introduce any user-visible changes to APIs, interfaces, or other behaviors.
How was this patch tested?
CI passed. Specifically:
patch_eagle.py, it was ensured that any related functional modules (if applicable) continue to work as expected, without introducing new regressions. This was typically verified by running the project's main test suite.