Br fix multi stream moe #1417
Closed
Br fix multi stream moe #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdmyzlp
force-pushed
the
br_fix_multi_stream_moe
branch
5 times, most recently
from
2743781 to
e322c53
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
- Coverage 27.39% 27.21% -0.18%
==========================================
Files 56 56
Lines 6191 6217 +26
==========================================
- Hits 1696 1692 -4
- Misses 4495 4525 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdmyzlp
force-pushed
the
br_fix_multi_stream_moe
branch
3 times, most recently
from
67c5113 to
e289203
Compare
Signed-off-by: sdmyzlp <lrwei2@petalmail.com>
Signed-off-by: sdmyzlp <lrwei2@petalmail.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: sdmyzlp <lrwei2@petalmail.com>
Signed-off-by: sdmyzlp <lrwei2@petalmail.com>
sdmyzlp
force-pushed
the
br_fix_multi_stream_moe
branch
from
e289203 to
c7f4b60
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
After #1229 , multistream moe with both mc2 and TP is broken, due to
all_gatheroperation in moe layer used to communicate the summation ofrouter_hidden_statesandshared_hidden_states, but onlyrouter_hidden_statesnow, causing a shape mismatch.Fix this by adding yet another
all_gatheroperation forshared_hidden_states.By the way, all these
all_gatheroperation exists due to a joint effect of:all_reduceinstead ofall_gather+reduce_scatterfor TP communication and,splitoperations at the entry of moe layer.This problem will be addressed by #1194 -like optimizations, after that is merged, both
splitandall_gatherhere can be removed.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested both offline, and by graph mode mla e2e testcase.