[CI/UT][BugFix] Fix sampling params #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhouXiang <zhouxiang100@huawei.com>
Signed-off-by: ZhouXiang <zhouxiang100@huawei.com>
Signed-off-by: ZhouXiang <zhouxiang100@huawei.com>
Collaborator
|
LGTM, thanks for the fixing! |
Collaborator
|
@ganyi1996ppo @wangxiyuan Please review and merge this pull request at your earliest convenience, as it is currently blocking several other PRs. @zhoux77899 Should also merge this to |
wangxiyuan
approved these changes
Jun 26, 2025
Collaborator
|
Quick merge to unblock the CI |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Fixes qwen3 w4a8 test case failed due to
sampling_paramsnot fixed andtorch_npuupdated.Does this PR introduce any user-facing change?
None.
How was this patch tested?