[Structured Output] Remove redundant check for grammar_bitmask
#1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shen-shanshan <467638484@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
+ Coverage 27.39% 27.42% +0.02%
==========================================
Files 56 56
Lines 6191 6269 +78
==========================================
+ Hits 1696 1719 +23
- Misses 4495 4550 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
approved these changes
Jun 26, 2025
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Jul 2, 2025
…m-project#1459) ### What this PR does / why we need it? Remove redundant check since we have check this at https://github.com/vllm-project/vllm-ascend/blob/main/vllm_ascend/worker/model_runner_v1.py#L1450. Signed-off-by: shen-shanshan <467638484@qq.com>
20 tasks
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
…m-project#1459) ### What this PR does / why we need it? Remove redundant check since we have check this at https://github.com/vllm-project/vllm-ascend/blob/main/vllm_ascend/worker/model_runner_v1.py#L1450. Signed-off-by: shen-shanshan <467638484@qq.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
…m-project#1459) ### What this PR does / why we need it? Remove redundant check since we have check this at https://github.com/vllm-project/vllm-ascend/blob/main/vllm_ascend/worker/model_runner_v1.py#L1450. Signed-off-by: shen-shanshan <467638484@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remove redundant check since we have check this at https://github.com/vllm-project/vllm-ascend/blob/main/vllm_ascend/worker/model_runner_v1.py#L1450.
Does this PR introduce any user-facing change?
How was this patch tested?