Skip to content

Conversation

@GDzhu01
Copy link
Contributor

@GDzhu01 GDzhu01 commented Jun 27, 2025

What this PR does / why we need it?

support pangu moe w8a8c8

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed with new added test.

@github-actions github-actions bot added documentation Improvements or additions to documentation module:core module:quantization labels Jun 27, 2025
@GDzhu01 GDzhu01 force-pushed the pangumoe_w8a8c8 branch 2 times, most recently from 722a9e3 to 26b7746 Compare June 27, 2025 10:01
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

❌ Patch coverage is 17.09845% with 160 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.19%. Comparing base (c30ddb8) to head (7de3736).
⚠️ Report is 581 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/quantization/w8a8.py 13.60% 146 Missing ⚠️
vllm_ascend/attention/attention_v1.py 25.00% 6 Missing ⚠️
vllm_ascend/quantization/quantizer.py 55.55% 4 Missing ⚠️
vllm_ascend/quantization/quant_config.py 25.00% 3 Missing ⚠️
vllm_ascend/platform.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
+ Coverage   27.39%   31.19%   +3.80%     
==========================================
  Files          56       60       +4     
  Lines        6191     6827     +636     
==========================================
+ Hits         1696     2130     +434     
- Misses       4495     4697     +202     
Flag Coverage Δ
unittests 31.19% <17.09%> (+3.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDzhu01 GDzhu01 force-pushed the pangumoe_w8a8c8 branch 2 times, most recently from 7cec5a5 to 20deb50 Compare June 27, 2025 12:20
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: zhuyilin <809721801@qq.com>
Copy link
Collaborator

@wangxiyuan wangxiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pangu weight is not avaliable, I'm OK with this PR. Please add test as well once pangu is avaiable.

@wangxiyuan wangxiyuan merged commit b308a7a into vllm-project:main Jun 28, 2025
25 checks passed
zhanghw0354 pushed a commit to zhanghw0354/vllm-ascend that referenced this pull request Jun 30, 2025
### What this PR does / why we need it?
support pangu moe w8a8c8

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed with new added test.

Signed-off-by: zhuyilin <809721801@qq.com>
Signed-off-by: zhanghw0354 <zhanghaiwen_yewu@cmss.chinamobile.com>
weijinqian0 pushed a commit to weijinqian0/vllm-ascend that referenced this pull request Jun 30, 2025
### What this PR does / why we need it?
support pangu moe w8a8c8

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed with new added test.

Signed-off-by: zhuyilin <809721801@qq.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
### What this PR does / why we need it?
support pangu moe w8a8c8

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed with new added test.

Signed-off-by: zhuyilin <809721801@qq.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
support pangu moe w8a8c8

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed with new added test.

Signed-off-by: zhuyilin <809721801@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation module:core module:quantization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants