Skip to content

Conversation

@Angazenn
Copy link
Collaborator

@Angazenn Angazenn commented Jun 28, 2025

What this PR does / why we need it?

This PR supports torchair graph mode with non-mla backend on both 800IA2 and 300I Duo platforms. The main change is to add attention_v1_torchair.py to support specific attention related operations that are required by torchair.

Does this PR introduce any user-facing change?

Before this PR, vLLM-Ascend only allows deepseek to use torchair. Now we can also use it with pangu. Besides, we add a support model list to control which type of models that can use torchair.

How was this patch tested?

We have test it with PanguProMoE on both 800IA2 and 300I Duo platforms, and model generates answer normally.

@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.60%. Comparing base (c30ddb8) to head (a129b93).
⚠️ Report is 613 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1506       +/-   ##
===========================================
+ Coverage   27.39%   51.60%   +24.20%     
===========================================
  Files          56       78       +22     
  Lines        6191     9474     +3283     
===========================================
+ Hits         1696     4889     +3193     
- Misses       4495     4585       +90     
Flag Coverage Δ
unittests 51.60% <100.00%> (+24.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Angazenn Angazenn force-pushed the torchair branch 6 times, most recently from 88cd32f to 31f0d92 Compare June 30, 2025 11:18
@Angazenn Angazenn force-pushed the torchair branch 2 times, most recently from 7427ef8 to 571ba99 Compare July 1, 2025 04:11
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Angazenn Angazenn force-pushed the torchair branch 4 times, most recently from c4a7f85 to c5a9254 Compare July 1, 2025 07:27
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 1, 2025
@Angazenn Angazenn changed the title [WIP]initial support for torchair with non-mla backend [CORE]initial support for torchair with non-mla backend Jul 1, 2025
@Angazenn Angazenn force-pushed the torchair branch 3 times, most recently from 83e54bc to a88bd2c Compare July 2, 2025 01:00
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Angazenn Angazenn force-pushed the torchair branch 4 times, most recently from ad27bb9 to 62998bb Compare July 2, 2025 12:42
Copy link
Collaborator

@wangxiyuan wangxiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:
move all torchair attention code to attention_v1_torchiar in the future

angazenn and others added 19 commits July 3, 2025 18:46
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: tianyitang <tangtianyi4@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: tianyitang <tangtianyi4@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
@wangxiyuan wangxiyuan merged commit a5f3359 into vllm-project:main Jul 3, 2025
22 checks passed
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
…#1506)

### What this PR does / why we need it?
This PR supports torchair graph mode with non-mla backend on both 800IA2
and 300I Duo platforms. The main change is to add
`attention_v1_torchair.py` to support specific attention related
operations that are required by torchair.

### Does this PR introduce _any_ user-facing change?
Before this PR, vLLM-Ascend only allows deepseek to use torchair. Now we
can also use it with pangu. Besides, we add a support model list to
control which type of models that can use torchair.

### How was this patch tested?
We have test it with PanguProMoE on both 800IA2 and 300I Duo platforms,
and model generates answer normally.

---------

Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: tianyitang <tangtianyi4@huawei.com>
Co-authored-by: angazenn <zengyanjia@huawei.com>
Co-authored-by: tianyitang <tangtianyi4@huawei.com>
Angazenn added a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…#1506)

### What this PR does / why we need it?
This PR supports torchair graph mode with non-mla backend on both 800IA2
and 300I Duo platforms. The main change is to add
`attention_v1_torchair.py` to support specific attention related
operations that are required by torchair.

### Does this PR introduce _any_ user-facing change?
Before this PR, vLLM-Ascend only allows deepseek to use torchair. Now we
can also use it with pangu. Besides, we add a support model list to
control which type of models that can use torchair.

### How was this patch tested?
We have test it with PanguProMoE on both 800IA2 and 300I Duo platforms,
and model generates answer normally.

---------

Signed-off-by: angazenn <zengyanjia@huawei.com>
Signed-off-by: tianyitang <tangtianyi4@huawei.com>
Co-authored-by: angazenn <zengyanjia@huawei.com>
Co-authored-by: tianyitang <tangtianyi4@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants