Skip to content

Conversation

@MengqingCao
Copy link
Collaborator

What this PR does / why we need it?

Add dispatch key for NPU, so that the log could be print correctly.

Now

executor_base.py:110] # CPU blocks: 220478, # CPU blocks: 21845

After this pr

executor_base.py:110] # NPU blocks: 220478, # CPU blocks: 21845

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI passed and log printed as above

@MengqingCao MengqingCao marked this pull request as draft February 7, 2025 06:33
@wangxiyuan
Copy link
Collaborator

wangxiyuan commented Feb 17, 2025

from torch expert suggestion: change the value to PrivateUse1.

Signed-off-by: MengqingCao <cmq0113@163.com>
@MengqingCao
Copy link
Collaborator Author

from torch expert suggestion: change the value to PrivateUse1.

Thanks a lot! This could fix the issue that torch does not recognize key npu.
But the log printed will become executor_base.py:110] # PrivateUse1 blocks: 220478, # CPU blocks: 21845, I'll fix this in vLLM.

@MengqingCao MengqingCao marked this pull request as ready for review February 17, 2025 02:53
@wangxiyuan
Copy link
Collaborator

from torch expert suggestion: change the value to PrivateUse1.

Thanks a lot! This could fix the issue that torch does not recognize key npu. But the log printed will become executor_base.py:110] # PrivateUse1 blocks: 220478, # CPU blocks: 21845, I'll fix this in vLLM.

Yes, the log in vllm should use device_name instead.

@MengqingCao
Copy link
Collaborator Author

Yes, the log in vllm should use device_name instead.

Agree

@wangxiyuan wangxiyuan merged commit dd425d6 into vllm-project:main Feb 21, 2025
10 checks passed
@MengqingCao MengqingCao deleted the npu branch February 25, 2025 08:49
ttanzhiqiang pushed a commit to ttanzhiqiang/vllm-ascend that referenced this pull request Apr 27, 2025
### What this PR does / why we need it?
Add dispatch key for NPU, so that the log could be print correctly.

Now
```
executor_base.py:110] # CPU blocks: 220478, # CPU blocks: 21845
```

After this pr
```
executor_base.py:110] # NPU blocks: 220478, # CPU blocks: 21845
```

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed and log printed as above

Signed-off-by: MengqingCao <cmq0113@163.com>
Apocalypse990923-qshi pushed a commit to Apocalypse990923-qshi/vllm-ascend that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants