-
Notifications
You must be signed in to change notification settings - Fork 542
[CI] Fix broken CI #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[CI] Fix broken CI #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7620067 to
7ead67c
Compare
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
- Coverage 60.93% 60.89% -0.04%
==========================================
Files 73 73
Lines 8147 8157 +10
==========================================
+ Hits 4964 4967 +3
- Misses 3183 3190 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yikun
approved these changes
Jul 19, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
1. vLLM commit vllm-project/vllm@45badd0 changed the pooling check logic which broken vLLM Ascend. 2. vLLM commit vllm-project/vllm@3e04107 requires higher version of transformers. The transformers version bug has been fixed by vllm-project/vllm@e936e40. We can safe to remove the version limit now. 3. vLLM commit vllm-project/vllm@2179372 added a new input `enable_eplb` for FusedMoe Ops This PR fix the broken CI. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@6a971ed Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
1. vLLM commit vllm-project/vllm@45badd0 changed the pooling check logic which broken vLLM Ascend. 2. vLLM commit vllm-project/vllm@3e04107 requires higher version of transformers. The transformers version bug has been fixed by vllm-project/vllm@e936e40. We can safe to remove the version limit now. 3. vLLM commit vllm-project/vllm@2179372 added a new input `enable_eplb` for FusedMoe Ops This PR fix the broken CI. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@6a971ed Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_eplbfor FusedMoe OpsThis PR fix the broken CI.