Skip to content

Conversation

@wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jul 19, 2025

  1. vLLM commit vllm-project/vllm@45badd0 changed the pooling check logic which broken vLLM Ascend.
  2. vLLM commit vllm-project/vllm@3e04107 requires higher version of transformers. The transformers version bug has been fixed by vllm-project/vllm@e936e40. We can safe to remove the version limit now.
  3. vLLM commit vllm-project/vllm@2179372 added a new input enable_eplb for FusedMoe Ops

This PR fix the broken CI.

@codecov
Copy link

codecov bot commented Jul 19, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.89%. Comparing base (2ee9046) to head (65d322b).
⚠️ Report is 547 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/worker/npu_input_batch.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
- Coverage   60.93%   60.89%   -0.04%     
==========================================
  Files          73       73              
  Lines        8147     8157      +10     
==========================================
+ Hits         4964     4967       +3     
- Misses       3183     3190       +7     
Flag Coverage Δ
unittests 60.89% <41.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@Yikun Yikun merged commit 2b726d8 into vllm-project:main Jul 19, 2025
24 checks passed
@wangxiyuan wangxiyuan deleted the fix_ci_0719 branch September 4, 2025 06:53
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
1. vLLM commit
vllm-project/vllm@45badd0
changed the pooling check logic which broken vLLM Ascend.
2. vLLM commit
vllm-project/vllm@3e04107
requires higher version of transformers. The transformers version bug
has been fixed by
vllm-project/vllm@e936e40.
We can safe to remove the version limit now.
3. vLLM commit
vllm-project/vllm@2179372
added a new input `enable_eplb` for FusedMoe Ops

This PR fix the broken CI.


- vLLM version: v0.9.2
- vLLM main:
vllm-project/vllm@6a971ed

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
1. vLLM commit
vllm-project/vllm@45badd0
changed the pooling check logic which broken vLLM Ascend.
2. vLLM commit
vllm-project/vllm@3e04107
requires higher version of transformers. The transformers version bug
has been fixed by
vllm-project/vllm@e936e40.
We can safe to remove the version limit now.
3. vLLM commit
vllm-project/vllm@2179372
added a new input `enable_eplb` for FusedMoe Ops

This PR fix the broken CI.


- vLLM version: v0.9.2
- vLLM main:
vllm-project/vllm@6a971ed

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants