[1/N][Refactor] Refactor AscendMetaData comments to make it clearer
#1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1967 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 86 86
Lines 9131 9131
=======================================
Hits 6528 6528
Misses 2603 2603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks, please rebase to fix the merge conflict |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: shen-shanshan <467638484@qq.com>
ApsarasX
approved these changes
Jul 24, 2025
wangxiyuan
approved these changes
Jul 24, 2025
Collaborator
Author
|
@wangxiyuan The CI has passed. |
6 tasks
shen-shanshan
changed the title
shen-shanshan
changed the title
AscendMetaData comments to make it clearer
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
…ect#1967) ### What this PR does / why we need it? Refactor the comments of `AscendMetaData` to make it clearer. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@f3137cd --------- Signed-off-by: shen-shanshan <467638484@qq.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
…ect#1967) ### What this PR does / why we need it? Refactor the comments of `AscendMetaData` to make it clearer. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@f3137cd --------- Signed-off-by: shen-shanshan <467638484@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Refactor the comments of
AscendMetaDatato make it clearer.Does this PR introduce any user-facing change?
How was this patch tested?