Skip to content

Conversation

@ApsarasX
Copy link
Collaborator

@ApsarasX ApsarasX commented Jul 25, 2025

What this PR does / why we need it?

Fix #2033

Sync vllm-project/vllm#14702 to solve grammar_bitmask IndexError caused by outdated apply_grammar_bitmask method

Does this PR introduce any user-facing change?

No

How was this patch tested?

Tested by upstream vllm

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.41%. Comparing base (75e28d0) to head (253d4e7).
⚠️ Report is 606 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         100      100           
  Lines       11208    11208           
=======================================
  Hits         8340     8340           
  Misses       2868     2868           
Flag Coverage Δ
unittests 74.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan
Copy link
Collaborator

Can you fix the CI error? We want to merge this before the new release

…bitmask method

Signed-off-by: ApsarasX <apsarax@outlook.com>
@ApsarasX ApsarasX force-pushed the community-grammar_bitmask-indexerror branch from 5184d2c to 253d4e7 Compare July 30, 2025 15:40
@wangxiyuan wangxiyuan merged commit 72eceff into vllm-project:main Jul 31, 2025
25 checks passed
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
…ar_bitmask` method (vllm-project#2022)

### What this PR does / why we need it?
Fix vllm-project#2033 

Sync vllm-project/vllm#14702 to solve
`grammar_bitmask` IndexError caused by outdated `apply_grammar_bitmask`
method

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Tested by upstream vllm


- vLLM version: v0.10.0
- vLLM main:
vllm-project/vllm@6e599ee

Signed-off-by: ApsarasX <apsarax@outlook.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…ar_bitmask` method (vllm-project#2022)

### What this PR does / why we need it?
Fix vllm-project#2033 

Sync vllm-project/vllm#14702 to solve
`grammar_bitmask` IndexError caused by outdated `apply_grammar_bitmask`
method

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Tested by upstream vllm


- vLLM version: v0.10.0
- vLLM main:
vllm-project/vllm@6e599ee

Signed-off-by: ApsarasX <apsarax@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: IndexError from sorted_bitmask[batch_index] = grammar_bitmask[orig_index]

2 participants