Skip to content

Conversation

@whx-sjtu
Copy link
Collaborator

@whx-sjtu whx-sjtu commented Jul 30, 2025

This PR is a quick fix of the accuracy problem mentioned in PR #1856.

Signed-off-by: whx-sjtu <2952154980@qq.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@MengqingCao
Copy link
Collaborator

It seems the implement of dispatch and combine is same as that in NaiveAll2AllManager, I think we'd better to call these communication ops through NaiveAll2AllManager, like #1856 does, instead of coping them here.

@wangxiyuan
Copy link
Collaborator

yes, if nothing changed with NaiveAll2AllManager, we should import from vllm directly instead of copy the code.

@whx-sjtu
Copy link
Collaborator Author

Got it, I will change this soon.

@MengqingCao
Copy link
Collaborator

Got it, I will change this soon.

To avoid duplicated work, I think #1856 is enough, and I'm working on adding accuracy test on dp + moe.

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whx-sjtu whx-sjtu closed this Aug 7, 2025
@whx-sjtu whx-sjtu deleted the fix_dp_accu branch October 20, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants