[bugfixed] fix the bug when run the inference of quantized ds-w8a8-mtp #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: curryliu <120010041@link.cuhk.edu.cn>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
MengqingCao
reviewed
Jul 31, 2025
| ) | ||
| if params_dtype is None: | ||
| params_dtype = torch.get_default_dtype() | ||
| self.params_dtype = params_dtype |
Collaborator
There was a problem hiding this comment.
plz add a todo here, we need to make a pr in vllm to finally fix this
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2134 +/- ##
==========================================
+ Coverage 75.05% 76.63% +1.58%
==========================================
Files 103 107 +4
Lines 11355 11977 +622
==========================================
+ Hits 8522 9179 +657
+ Misses 2833 2798 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: curryliu <120010041@link.cuhk.edu.cn>
Collaborator
|
LGTM, plz update the pr message to clearly describe the bug it fixes |
zzzzwwjj
approved these changes
Aug 4, 2025
wangxiyuan
approved these changes
Aug 4, 2025
zzhx1
pushed a commit
to lidenghui1110/vllm-ascend
that referenced
this pull request
Aug 11, 2025
vllm-project#2134) When run the inference of ds-w8a8-mtp, it reported 'ParamllelLMhead has no attribute 'params_dtype''. 1. add wrapper of vocab_parallel_embedding, fixed the bugs when running deepseek-w8a8-mtp Signed-off-by: curryliu <120010041@link.cuhk.edu.cn> - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@ad57f23 --------- Signed-off-by: curryliu <120010041@link.cuhk.edu.cn>
zzhx1
pushed a commit
to lidenghui1110/vllm-ascend
that referenced
this pull request
Aug 11, 2025
vllm-project#2134) When run the inference of ds-w8a8-mtp, it reported 'ParamllelLMhead has no attribute 'params_dtype''. 1. add wrapper of vocab_parallel_embedding, fixed the bugs when running deepseek-w8a8-mtp Signed-off-by: curryliu <120010041@link.cuhk.edu.cn> - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@ad57f23 --------- Signed-off-by: curryliu <120010041@link.cuhk.edu.cn>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
vllm-project#2134) When run the inference of ds-w8a8-mtp, it reported 'ParamllelLMhead has no attribute 'params_dtype''. 1. add wrapper of vocab_parallel_embedding, fixed the bugs when running deepseek-w8a8-mtp Signed-off-by: curryliu <120010041@link.cuhk.edu.cn> - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@ad57f23 --------- Signed-off-by: curryliu <120010041@link.cuhk.edu.cn>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
vllm-project#2134) When run the inference of ds-w8a8-mtp, it reported 'ParamllelLMhead has no attribute 'params_dtype''. 1. add wrapper of vocab_parallel_embedding, fixed the bugs when running deepseek-w8a8-mtp Signed-off-by: curryliu <120010041@link.cuhk.edu.cn> - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@ad57f23 --------- Signed-off-by: curryliu <120010041@link.cuhk.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run the inference of ds-w8a8-mtp, it reported 'ParamllelLMhead has no attribute 'params_dtype''.
Signed-off-by: curryliu 120010041@link.cuhk.edu.cn