Skip to content

Conversation

@wxsIcey
Copy link
Collaborator

@wxsIcey wxsIcey commented Aug 1, 2025

What this PR does / why we need it?

This PR fix accuracy test related to #2073, users can now perform accuracy tests on multiple models simultaneously and generate different report files by running:

cd ~/vllm-ascend
pytest -sv ./tests/e2e/singlecard/models/test_lm_eval_correctness.py \
          --config-list-file ./tests/e2e/singlecard/models/configs/accuracy.txt

Does this PR introduce any user-facing change?

no

How was this patch tested?

image

Signed-off-by: Icey <1790571317@qq.com>
@wxsIcey wxsIcey added accuracy-test enable all accuracy test for PR ready-for-test start test by label for PR labels Aug 1, 2025
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: Icey <1790571317@qq.com>
@wxsIcey wxsIcey added accuracy-test enable all accuracy test for PR ready-for-test start test by label for PR and removed ready-for-test start test by label for PR accuracy-test enable all accuracy test for PR labels Aug 1, 2025
@wxsIcey wxsIcey marked this pull request as ready for review August 1, 2025 06:18
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.67%. Comparing base (86bdde1) to head (da92666).
⚠️ Report is 653 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2163      +/-   ##
==========================================
- Coverage   76.89%   76.67%   -0.22%     
==========================================
  Files         107      107              
  Lines       11883    11968      +85     
==========================================
+ Hits         9137     9177      +40     
- Misses       2746     2791      +45     
Flag Coverage Δ
unittests 76.67% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wxsIcey wxsIcey requested a review from Yikun August 4, 2025 12:47
if single_config:
metafunc.parametrize("config_filename",
[Path(single_config).resolve()])
if metafunc.config.getoption("--config-list-file"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why reorder this?

the original thoughts is that --config has higer priority than --config-list-file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the --config option has default settings, if --config is checked first, the logic for --config-list-file will definitely not be executed.

parser.addoption(
"--report-dir",
action="store",
default="./benchmarks/accuracy",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to keep current path, ./, otherwise the ./benchmarks/accuracy is required.

Copy link
Collaborator Author

@wxsIcey wxsIcey Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wxsIcey wxsIcey closed this by deleting the head repository Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accuracy-test enable all accuracy test for PR module:tests ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants