Skip to content

Fix accuracy test create PR #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Fix accuracy test create PR #2274

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c640b06
Fix accuracy test create PR
wxsIcey Aug 8, 2025
ae6775d
fix
wxsIcey Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/accuracy_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,14 @@ jobs:

outputs:
model_name: ${{ steps.set_output.outputs.model_name }}

vllm_ascend_version: ${{ env.GHA_VLLM_ASCEND_VERSION }}

create_pr:
runs-on: ubuntu-latest
needs: accuracy_tests
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.vllm-ascend-version == 'latest' }}
env:
UPSTREAM_REPO: vllm-project/vllm-ascend

steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand All @@ -258,7 +258,7 @@ jobs:
TIMESTAMP=$(date +%Y%m%d%H%M%S)
BRANCH_NAME="auto-pr/accuracy-report-${TIMESTAMP}"
echo "BRANCH_NAME=${BRANCH_NAME}" >> $GITHUB_ENV
git checkout -B "${BRANCH_NAME}" upstream/${{ github.event.inputs.vllm-ascend-version }}
git checkout -B "${BRANCH_NAME}" upstream/main
Copy link
Collaborator

@Yikun Yikun Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means currently we only support submit report in main branch:

image

We should think how to make it more general for all branches, first select the branch, and use the branch to run vllm-ascend branch.

Copy link
Collaborator Author

@wxsIcey wxsIcey Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think it can be implemented in this way. For example, when the next latest version is v0.10.0rc2, first check whether v0.10.0-dev exists in the repository. If so, submit a report PR to v0.10.0-dev. Otherwise, submit a report PR to main.


- name: Download only current run reports
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -299,7 +299,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }}
run: |
git add ./docs/source/developer_guide/evaluation/accuracy_report/*.md
git commit -s -m "[Doc] Update accuracy reports for ${{ github.event.inputs.vllm-ascend-version }}"
git commit -s -m "[Doc] Update accuracy reports for ${{ needs.accuracy_tests.outputs.vllm_ascend_version }}"
git push -f origin "${{ env.BRANCH_NAME }}"

- name: Create PR in upstream via API
Expand All @@ -311,8 +311,8 @@ jobs:
owner: 'vllm-project',
repo: 'vllm-ascend',
head: `vllm-ascend-ci:${{ env.BRANCH_NAME }}`,
base: '${{ github.event.inputs.vllm-ascend-version }}',
title: `[Doc] Update accuracy reports for ${{ github.event.inputs.vllm-ascend-version }}`,
base: 'main',
title: `[Doc] Update accuracy reports for ${{ needs.accuracy_tests.outputs.vllm_ascend_version }}`,
body: `The accuracy results running on NPU Altlas A2 have changed, updating reports for: All models (Qwen3-30B-A3B, Qwen2.5-VL-7B-Instruct, Qwen3-8B-Base, DeepSeek-V2-Lite)

- [Workflow run][1]
Expand Down
Loading