Skip to content

Conversation

@zhangxinyuehfad
Copy link
Contributor

@zhangxinyuehfad zhangxinyuehfad commented Aug 30, 2025

What this PR does / why we need it?

  1. Fix num_hidden_layers on Qwen2-Audio and Qwen2.5-Omni when V1
  2. add audio_feature_lengths and use_audio_in_video when V0

Does this PR introduce any user-facing change?

Users can use Qwen2-Audio and Qwen2.5-Omni in V1 or V0

How was this patch tested?

CI passed with new added test.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Qwen2-Audio and Qwen2.5-Omni models by fixing how num_hidden_layers is retrieved from the model configuration and adding necessary parameters for audio processing. It also adds new dependencies and tests for audio models. My review identifies a critical bug in the new recursive search function that could fail for certain configuration structures, and a minor but potentially problematic formatting issue in the development requirements file. I've provided suggestions to fix both issues.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_v0.9.1 branch 2 times, most recently from a7907d2 to dcfe89d Compare August 30, 2025 09:45
@github-actions github-actions bot added documentation Improvements or additions to documentation module:tests module:core labels Aug 30, 2025
@wangxiyuan
Copy link
Collaborator

please fix the merge conflic

@github-actions
Copy link

github-actions bot commented Sep 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: hfadzxy <starmoon_zhang@163.com>
@zhangxinyuehfad
Copy link
Contributor Author

please fix the merge conflic

done

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts module:core module:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants