-
Notifications
You must be signed in to change notification settings - Fork 544
[0.9.1][Fixbug] Fix num_hidden_layers on Qwen2-Audio and Qwen2.5-Omni #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.9.1-dev
Are you sure you want to change the base?
[0.9.1][Fixbug] Fix num_hidden_layers on Qwen2-Audio and Qwen2.5-Omni #2656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Qwen2-Audio and Qwen2.5-Omni models by fixing how num_hidden_layers is retrieved from the model configuration and adding necessary parameters for audio processing. It also adds new dependencies and tests for audio models. My review identifies a critical bug in the new recursive search function that could fail for certain configuration structures, and a minor but potentially problematic formatting issue in the development requirements file. I've provided suggestions to fix both issues.
5e680c7 to
8a68388
Compare
a7907d2 to
dcfe89d
Compare
|
please fix the merge conflic |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
dcfe89d to
a956298
Compare
done |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
audio_feature_lengthsanduse_audio_in_videowhen V0Does this PR introduce any user-facing change?
Users can use Qwen2-Audio and Qwen2.5-Omni in V1 or V0
How was this patch tested?
CI passed with new added test.