Remove unused code in fused_moe.py #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes a redundant line of code in fused_moe.py, which improves code clarity. My review confirms this change is beneficial. I have also pointed out other nearby unused variables that could also be removed to align with the goal of this PR.
| # When all_reduce_merge is in progress, shared_experts does not do all_reduce in mlp, but waits until shared_experts+router_experts are completed before doing all_reduce | ||
| shared_hidden_states = shared_experts(hidden_states) | ||
|
|
||
| mc2_mask = forward_context.mc2_mask |
Contributor
There was a problem hiding this comment.
This removal is correct as mc2_mask was already assigned at line 408. In the spirit of removing unused code, the variables quantized_x_for_share and dynamic_scale_for_share initialized at line 410 also appear to be unused. They are always None and are passed to self.quant_method.apply. Removing them and their usage in the apply call would further improve code clarity and maintainability.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
=======================================
Coverage 72.61% 72.61%
=======================================
Files 154 154
Lines 21319 21317 -2
=======================================
Hits 15480 15480
+ Misses 5839 5837 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
approved these changes
Sep 8, 2025
1Fire4
pushed a commit
to 1Fire4/vllm-ascend
that referenced
this pull request
Sep 9, 2025
### What this PR does / why we need it? line 408 already declared mc2_mask , remove duplicated unused code ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@60f0843 Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com> Signed-off-by: 1Fire4 <wangdingyi2@huawei.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Sep 10, 2025
### What this PR does / why we need it? line 408 already declared mc2_mask , remove duplicated unused code ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@60f0843 Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com>
offline893
pushed a commit
to offline893/vllm-ascend
that referenced
this pull request
Sep 16, 2025
### What this PR does / why we need it? line 408 already declared mc2_mask , remove duplicated unused code ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@60f0843 Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com> Signed-off-by: offline0806 <z00858301@china.huawei.com>
wangxiaoteng888
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Sep 25, 2025
### What this PR does / why we need it? line 408 already declared mc2_mask , remove duplicated unused code ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@60f0843 Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
### What this PR does / why we need it? line 408 already declared mc2_mask , remove duplicated unused code ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@60f0843 Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? line 408 already declared mc2_mask , remove duplicated unused code ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@60f0843 Signed-off-by: machenglong <machenglong_yewu@cmss.chinamobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
line 408 already declared mc2_mask , remove duplicated unused code
Does this PR introduce any user-facing change?
no
How was this patch tested?
CI passed with existing test.