[TEST] Speed up DS V2 accuracy test and turn up accuracy baseline #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the expected accuracy and batch size for the DeepSeek-V2-Lite model's end-to-end tests. The changes bring the configuration closer to observed results. My review provides suggestions to further improve the precision of the accuracy values in the test configuration, making them more specific to each metric based on the provided accuracy report. This will enhance the reliability and maintainability of the tests.
vllm-ascend-ci
added
accuracy-test
Yikun
changed the title
Yikun
approved these changes
Sep 19, 2025
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Sep 22, 2025
…lm-project#3047) ### What this PR does / why we need it? 1. update expected accuracy for DeepSeek-V2-Lite 2. add batch size ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Accuracy CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@838d711 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
…lm-project#3047) ### What this PR does / why we need it? 1. update expected accuracy for DeepSeek-V2-Lite 2. add batch size ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Accuracy CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@838d711 Signed-off-by: hfadzxy <starmoon_zhang@163.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
…lm-project#3047) ### What this PR does / why we need it? 1. update expected accuracy for DeepSeek-V2-Lite 2. add batch size ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Accuracy CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@838d711 Signed-off-by: hfadzxy <starmoon_zhang@163.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
…lm-project#3047) ### What this PR does / why we need it? 1. update expected accuracy for DeepSeek-V2-Lite 2. add batch size ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Accuracy CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@838d711 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…lm-project#3047) ### What this PR does / why we need it? 1. update expected accuracy for DeepSeek-V2-Lite 2. add batch size ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Accuracy CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@838d711 Signed-off-by: hfadzxy <starmoon_zhang@163.com> Signed-off-by: hwhaokun <haokun0405@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?