-
Notifications
You must be signed in to change notification settings - Fork 542
[CI] Upgrade vLLM to 20250920 (c60e613) and address config break #3067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 74.76% 71.93% -2.84%
==========================================
Files 150 168 +18
Lines 20891 23554 +2663
==========================================
+ Hits 15620 16944 +1324
- Misses 5271 6610 +1339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
| logits_to_return = logits | ||
| elif self.logprobs_mode == LogprobsMode.PROCESSED_LOGPROBS: | ||
| logits_to_return = logits.log_softmax(dim=-1, dtype=torch.float32) | ||
| if vllm_version_is("0.10.2"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> from enum import Enum
>>> class Color(Enum):
... RED = "red"
... GREEN = "green"
... BLUE = "blue"
...
>>> Color.RED
<Color.RED: 'red'>
>>> Color.RED=="red"
False
>>>Here is the note why we need this
…m-project#3067) ### What this PR does / why we need it? Bump main to vllm-project/vllm@c60e613 - Updated imports in `vllm.config` to `vllm.config.model`(vllm-project/vllm@aed1687) vllm-project/vllm#25252 - Refactored `vllm_ascend/sample/sampler.py` to use string values for `logprobs_mode` instead of the `LogprobsMode` enum, simplifying logprobs mode handling and improving compatibility with recent vLLM changes (vllm-project/vllm@aed1687) vllm-project/vllm#25252 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@6d8246a --------- Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
…m-project#3067) ### What this PR does / why we need it? Bump main to vllm-project/vllm@c60e613 - Updated imports in `vllm.config` to `vllm.config.model`(vllm-project/vllm@aed1687) vllm-project/vllm#25252 - Refactored `vllm_ascend/sample/sampler.py` to use string values for `logprobs_mode` instead of the `LogprobsMode` enum, simplifying logprobs mode handling and improving compatibility with recent vLLM changes (vllm-project/vllm@aed1687) vllm-project/vllm#25252 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@6d8246a --------- Signed-off-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk>
…m-project#3067) ### What this PR does / why we need it? Bump main to vllm-project/vllm@c60e613 - Updated imports in `vllm.config` to `vllm.config.model`(vllm-project/vllm@aed1687) vllm-project/vllm#25252 - Refactored `vllm_ascend/sample/sampler.py` to use string values for `logprobs_mode` instead of the `LogprobsMode` enum, simplifying logprobs mode handling and improving compatibility with recent vLLM changes (vllm-project/vllm@aed1687) vllm-project/vllm#25252 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@6d8246a --------- Signed-off-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk>
…m-project#3067) ### What this PR does / why we need it? Bump main to vllm-project/vllm@c60e613 - Updated imports in `vllm.config` to `vllm.config.model`(vllm-project/vllm@aed1687) vllm-project/vllm#25252 - Refactored `vllm_ascend/sample/sampler.py` to use string values for `logprobs_mode` instead of the `LogprobsMode` enum, simplifying logprobs mode handling and improving compatibility with recent vLLM changes (vllm-project/vllm@aed1687) vllm-project/vllm#25252 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@6d8246a --------- Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
What this PR does / why we need it?
Bump main to vllm-project/vllm@c60e613
Updated imports in
vllm.configtovllm.config.model(vllm-project/vllm@aed1687) MoveModelConfigfromconfig/__init__.pytoconfig/model.pyvllm#25252Refactored
vllm_ascend/sample/sampler.pyto use string values forlogprobs_modeinstead of theLogprobsModeenum, simplifying logprobs mode handling and improving compatibility with recent vLLM changes (vllm-project/vllm@aed1687) MoveModelConfigfromconfig/__init__.pytoconfig/model.pyvllm#25252Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed