-
Notifications
You must be signed in to change notification settings - Fork 545
[Doc] pin version that can stable running 310I Duo to vllm-ascend v0.10.0rc1 #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to pin the documentation for the 310I Duo to a stable, working version of vllm-ascend. The changes update the FAQs and the single-node tutorial for the Atlas 300I series. My review has identified a critical inconsistency in the version number being pinned. The PR title and one part of the documentation refer to v0.10.0rc1, while other parts refer to v0.10.1rc1. It is crucial to resolve this discrepancy to avoid user confusion. I have provided suggestions to align the version with the one mentioned in the pull request title.
4e898b9 to
c5b447f
Compare
…v0.10.0.rc1 Signed-off-by: leo-pony <nengjunma@outlook.com>
c5b447f to
11c5e81
Compare
Yikun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Signed-off-by: leo-pony <nengjunma@outlook.com>
…10.0rc1 (vllm-project#3455) Pin version that can stable running 310I Duo to vllm-ascend v0.10.0rc1. ### What this PR does / why we need it? Since PR vllm-project#2614 310I Duo been broken. Although we are currently working on fixing the issue with the 310I Duo being broken, there is no confirmed timeline for a fix in the short term. To allow users to quickly find a working version instead of going back and forth on trial and error, this PR fixes the version in the 310I Duo guide. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? NA - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 --------- Signed-off-by: leo-pony <nengjunma@outlook.com> Signed-off-by: MrZ20 <2609716663@qq.com>
…10.0rc1 (vllm-project#3455) Pin version that can stable running 310I Duo to vllm-ascend v0.10.0rc1. ### What this PR does / why we need it? Since PR vllm-project#2614 310I Duo been broken. Although we are currently working on fixing the issue with the 310I Duo being broken, there is no confirmed timeline for a fix in the short term. To allow users to quickly find a working version instead of going back and forth on trial and error, this PR fixes the version in the 310I Duo guide. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? NA - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 --------- Signed-off-by: leo-pony <nengjunma@outlook.com> Signed-off-by: MrZ20 <2609716663@qq.com>
Pin version that can stable running 310I Duo to vllm-ascend v0.10.0rc1.
What this PR does / why we need it?
Since PR #2614 310I Duo been broken. Although we are currently working on fixing the issue with the 310I Duo being broken, there is no confirmed timeline for a fix in the short term. To allow users to quickly find a working version instead of going back and forth on trial and error, this PR fixes the version in the 310I Duo guide.
Does this PR introduce any user-facing change?
NA
How was this patch tested?
NA