Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Make code more clean #35

Closed
wants to merge 1 commit into from
Closed

[Misc] Make code more clean #35

wants to merge 1 commit into from

Conversation

wangxiyuan
Copy link
Collaborator

This PR make the code more clean:

  1. remove useless try catch
  2. remove current_platform usage in vllm-ascend
  3. set NPU string to constant
  4. remove useless function
  5. move useless global function into Class

@wangxiyuan
Make code more clean
8e8b29f 
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@wangxiyuan wangxiyuan changed the title Make code more clean [Misc] Make code more clean Feb 11, 2025
@wangxiyuan
Copy link
Collaborator Author

Do it onec code is stable enough

@wangxiyuan wangxiyuan closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wangxiyuan