Skip to content

Conversation

@wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Oct 28, 2025

check_and_update_config function become large and hard for maintain.

This PR refactor this function.

  1. Add more comment for each step
  2. move compilation related code to compilation module
  3. remove ueless _set_cudagraph_sizes logic.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the check_and_update_config function by extracting compilation-related logic into a new vllm_ascend/compilation/utils.py file. This improves code organization and readability in vllm_ascend/platform.py. The changes are well-structured. However, I found a critical issue in the newly added _update_aclgraph_sizes function that could lead to a ZeroDivisionError or an IndexError, causing the application to crash. I have provided a code suggestion to fix these issues and improve the sampling logic.

@wangxiyuan wangxiyuan added the ready read for review label Oct 28, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@wangxiyuan wangxiyuan force-pushed the refactor_check_and_update branch from d213335 to e8f3d41 Compare October 28, 2025 09:46
@wangxiyuan wangxiyuan added the ready-for-test start test by label for PR label Oct 28, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed ready read for review merge-conflicts labels Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant