Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Mar 28, 2025

What this PR does / why we need it?

After extensive testing, we are happy to say that guided_decoding is fully supported by npu, in this pr, we add guided_decoding integrated with our test, mainly does the following things:

  1. test v0 supported backends including "outlines", "lm-format-enforcer","xgrammar"
  2. test v1 supported backends including "guidance", "xgrammar"

@Potabk Potabk force-pushed the ci_guided_decoding branch 2 times, most recently from 6f18d1e to 31e8138 Compare April 2, 2025 07:19
@Potabk Potabk force-pushed the ci_guided_decoding branch 7 times, most recently from c38051e to bd46e71 Compare April 15, 2025 15:14
@Potabk Potabk force-pushed the ci_guided_decoding branch 3 times, most recently from dc4ce23 to 3838107 Compare April 21, 2025 02:03
@Potabk
Copy link
Collaborator Author

Potabk commented Apr 21, 2025

@wangxiyuan CI is almost passed, I think it is ready to integrate this test

print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}")


@pytest.mark.skipif(os.getenv("VLLM_USE_V1") == "1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think V1 works now. @shen-shanshan

Potabk added 2 commits April 22, 2025 02:57
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk force-pushed the ci_guided_decoding branch from 3838107 to 0676604 Compare April 22, 2025 02:57
@wangxiyuan wangxiyuan merged commit cf6ab42 into vllm-project:main Apr 22, 2025
13 checks passed
@Potabk Potabk deleted the ci_guided_decoding branch April 22, 2025 10:48
ttanzhiqiang pushed a commit to ttanzhiqiang/vllm-ascend that referenced this pull request Apr 27, 2025
### What this PR does / why we need it?
After extensive testing, we are happy to say that guided_decoding is
fully supported by npu, in this pr, we add guided_decoding integrated
with our test, mainly does the following things:
1. test v0 supported backends including ` "outlines",
"lm-format-enforcer","xgrammar"`
2. test v1 supported backends including ` "guidance", "xgrammar"`

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
After extensive testing, we are happy to say that guided_decoding is
fully supported by npu, in this pr, we add guided_decoding integrated
with our test, mainly does the following things:
1. test v0 supported backends including ` "outlines",
"lm-format-enforcer","xgrammar"`
2. test v1 supported backends including ` "guidance", "xgrammar"`

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants