[dist] fix communicator patch #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MengqingCao <cmq0113@163.com>
Collaborator
Author
|
plz merge after @whx-sjtu approved |
Collaborator
|
LGTM |
wangxiyuan
pushed a commit
that referenced
this pull request
Feb 14, 2025
### What this PR does / why we need it? fix communicator patch so parallel could work. see #52 Signed-off-by: MengqingCao <cmq0113@163.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Feb 21, 2025
Fix communicator patch for distributed inferencing. We should patch `GroupCoordinator` with its module, and just before initializing distributed env. So that the patch won't be shadowed by the import of `init_distributed_environment` in `worker.py` Signed-off-by: MengqingCao <cmq0113@163.com> Signed-off-by: angazenn <zengyanjia@huawei.com>
ttanzhiqiang
pushed a commit
to ttanzhiqiang/vllm-ascend
that referenced
this pull request
Apr 27, 2025
### What this PR does / why we need it? fix communicator patch so parallel could work. see vllm-project#52 Signed-off-by: MengqingCao <cmq0113@163.com>
ZhengWG
pushed a commit
to ZhengWG/vllm-ascend
that referenced
this pull request
Jun 18, 2025
delete print in funsed_moe forward
offline893
pushed a commit
to offline893/vllm-ascend
that referenced
this pull request
Sep 9, 2025
delete print in funsed_moe forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix communicator patch for distributed inferencing.
We should patch
GroupCoordinatorwith its module, and just before initializing distributed env. So that the patch won't be shadowed by the import ofinit_distributed_environmentinworker.py