[Doc] Add vllm-ascend usage doc & fix doc format #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
|
No need to update installation and quick start doc. They will be updated in new PR. |
Collaborator
Author
ok. |
Yikun
reviewed
Feb 14, 2025
MengqingCao
reviewed
Feb 14, 2025
Yikun
reviewed
Feb 14, 2025
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Yikun
approved these changes
Feb 14, 2025
Collaborator
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
Overall, it has been greatly improved compared to the previous version, thank you!
docs/source/tutorials.md
Outdated
| ```bash | ||
| # Use Modelscope mirror to speed up model download | ||
| export VLLM_USE_MODELSCOPE=True | ||
| export MODELSCOPE_CACHE=/root/models/ |
Collaborator
There was a problem hiding this comment.
Suggested change
| export MODELSCOPE_CACHE=/root/models/ |
you can use default cache -v /root/.cache:/root/.cache
docs/source/tutorials.md
Outdated
| -v /usr/local/Ascend/driver/lib64/:/usr/local/Ascend/driver/lib64/ \ | ||
| -v /usr/local/Ascend/driver/version.info:/usr/local/Ascend/driver/version.info \ | ||
| -v /etc/ascend_install.info:/etc/ascend_install.info \ | ||
| -v /root/models:/root/models \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| -v /root/models:/root/models \ | |
| -v /root/.cache:/root/.cache \ |
docs/source/tutorials.md
Outdated
| -v /usr/local/Ascend/driver/lib64/:/usr/local/Ascend/driver/lib64/ \ | ||
| -v /usr/local/Ascend/driver/version.info:/usr/local/Ascend/driver/version.info \ | ||
| -v /etc/ascend_install.info:/etc/ascend_install.info \ | ||
| -v /root/models:/root/models \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| -v /root/models:/root/models \ | |
| -v /root/.cache:/root/.cache \ |
docs/source/tutorials.md
Outdated
| -v /root/models:/root/models \ | ||
| -p 8000:8000 \ | ||
| -e VLLM_USE_MODELSCOPE=True \ | ||
| -e MODELSCOPE_CACHE=/root/models/ \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| -e MODELSCOPE_CACHE=/root/models/ \ |
docs/source/tutorials.md
Outdated
| -v /usr/local/Ascend/driver/lib64/:/usr/local/Ascend/driver/lib64/ \ | ||
| -v /usr/local/Ascend/driver/version.info:/usr/local/Ascend/driver/version.info \ | ||
| -v /etc/ascend_install.info:/etc/ascend_install.info \ | ||
| -v /root/models:/root/models \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| -v /root/models:/root/models \ | |
| -v /root/.cache:/root/.cache \ |
docs/source/tutorials.md
Outdated
| ```bash | ||
| # Use Modelscope mirror to speed up model download | ||
| export VLLM_USE_MODELSCOPE=True | ||
| export MODELSCOPE_CACHE=/root/models/ |
Collaborator
There was a problem hiding this comment.
Suggested change
| export MODELSCOPE_CACHE=/root/models/ |
docs/source/tutorials.md
Outdated
Comment on lines
160
to
164
| def clean_up(): | ||
| destroy_model_parallel() | ||
| destroy_distributed_environment() | ||
| gc.collect() | ||
| torch.npu.empty_cache() |
Collaborator
There was a problem hiding this comment.
Looks like a little bit wired, would you mind taking a look? @wangxiyuan
Collaborator
There was a problem hiding this comment.
since this is only a simple example, no need to do
del llm
clean_up()
Collaborator
There was a problem hiding this comment.
When we using mp as distributed_executor_backend, the clean up must be done by hand, otherwise will raise error when exiting process. This is a bug in vLLM.
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Collaborator
|
After this PR merged, pls also backport this to v0.7.1 branch. |
ttanzhiqiang
pushed a commit
to ttanzhiqiang/vllm-ascend
that referenced
this pull request
Apr 27, 2025
### What this PR does / why we need it? 1. Add vllm-ascend tutorial doc for Qwen/Qwen2.5-7B-Instruct model serving doc 2. fix format of files in `docs` dir, e.g. format tables, add underline for links, add line feed... ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as API, interface or other behavior changes. Documentation-only updates are not considered user-facing changes. --> no. ### How was this patch tested? doc CI passed --------- Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
ZhengWG
pushed a commit
to ZhengWG/vllm-ascend
that referenced
this pull request
Jun 18, 2025
fix bugs caused by variable name old_placemet
offline893
pushed a commit
to offline893/vllm-ascend
that referenced
this pull request
Sep 9, 2025
fix bugs caused by variable name old_placemet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
docsdir, e.g. format tables, add underline for links, add line feed...Does this PR introduce any user-facing change?
no.
How was this patch tested?
no.