Skip to content

Conversation

@mengwei805
Copy link
Collaborator

@mengwei805 mengwei805 commented Apr 18, 2025

What this PR does / why we need it?

add spec decode e2e UT

  1. add test_multistep_correctness.py;
  2. open tests/spec_decode/e2e/test_eagle_correctness.py 2 cases by using modelscope weights;

fix chunked prefill bug

  1. add support for atten_mask only has 1 element

Does this PR introduce any user-facing change?

None

How was this patch tested?

tested by CI and local test passed.

@mengwei805 mengwei805 changed the title [5/N][CI/UT]add spec decode e2e UT && fix chunk prefill bug [5/N][CI/UT]add spec decode e2e UT && [BUGFIX]fix chunk prefill bug Apr 18, 2025
@mengwei805 mengwei805 force-pushed the v0.7.3-dev-sd-ut-part4 branch 3 times, most recently from 9c5167d to 8d5f947 Compare April 18, 2025 04:51
@wangxiyuan wangxiyuan changed the title [5/N][CI/UT]add spec decode e2e UT && [BUGFIX]fix chunk prefill bug [0.7.3][5/N][CI/UT]add spec decode e2e UT && [BUGFIX]fix chunk prefill bug Apr 18, 2025
@mengwei805 mengwei805 force-pushed the v0.7.3-dev-sd-ut-part4 branch 7 times, most recently from 836df31 to e7cebc0 Compare April 20, 2025 13:27
Co-authored-by: mengwei805 <mengwei25@huawei.com>
Co-authored-by: XWFAlone <xuewenfei2@huawei.com>
Signed-off-by: mengwei805 <mengwei25@huawei.com>
@mengwei805 mengwei805 force-pushed the v0.7.3-dev-sd-ut-part4 branch from e7cebc0 to 187e8ab Compare April 21, 2025 07:41
@wangxiyuan
Copy link
Collaborator

Thanks for the PR. It's really nice.

@wangxiyuan wangxiyuan merged commit 4c41672 into vllm-project:v0.7.3-dev Apr 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants