[V1] Make V1 engine backward compatible #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiz-liu
force-pushed
the
main
branch
4 times, most recently
from
d032ee2 to
306654e
Compare
Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Collaborator
There was a problem hiding this comment.
Looks good to me, but the changes in this file seems not related to the topic of this PR
Collaborator
Author
There was a problem hiding this comment.
Actually, I spoke with Xiyuan and confirmed that this test case does not require setting the vllm config. As a result, I reverted it to its original state. The reason for this change is that the CI triggered a vllm config-related error while I was addressing the enforce_eager issue, which led me to this test case.
Collaborator
|
@wangxiyuan can you please review this PR, we should merge this PR asap. |
Collaborator
|
lgtm |
wangxiyuan
approved these changes
Apr 24, 2025
wangxiyuan
changed the title
ttanzhiqiang
pushed a commit
to ttanzhiqiang/vllm-ascend
that referenced
this pull request
Apr 27, 2025
### What this PR does / why we need it? Enforce eager mode in the V1 engine ahead of the upcoming CANN and torch_npu releases. ### Does this PR introduce _any_ user-facing change? After this change, users will no longer need to manually set enforce_eager=True. ### How was this patch tested? Test it with regular offline inference examples. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Enforce eager mode in the V1 engine ahead of the upcoming CANN and torch_npu releases. ### Does this PR introduce _any_ user-facing change? After this change, users will no longer need to manually set enforce_eager=True. ### How was this patch tested? Test it with regular offline inference examples. Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Enforce eager mode in the V1 engine ahead of the upcoming CANN and torch_npu releases.
Does this PR introduce any user-facing change?
After this change, users will no longer need to manually set enforce_eager=True.
How was this patch tested?
Test it with regular offline inference examples.