[v0.7.3] Add openEuler based container image #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxsIcey
changed the title
Yikun
reviewed
Apr 26, 2025
Dockerfile.openEuler
Outdated
Comment on lines
21
to
23
| ARG COMPILE_CUSTOM_KERNELS=1 | ||
|
|
||
| ENV COMPILE_CUSTOM_KERNELS=${COMPILE_CUSTOM_KERNELS} |
There was a problem hiding this comment.
This shouldn't be enabled in v0.7.3
Dockerfile.openEuler
Outdated
| RUN yum update -y && \ | ||
| yum install -y python3-pip git vim wget net-tools gcc gcc-c++ make cmake numactl-devel && \ | ||
| rm -rf /var/cache/yum &&\ | ||
| rm -rf /tmp/* |
There was a problem hiding this comment.
not sure why tmp is here, it's a danger behavior to clean up other path beside yum related. rm -rf /var/cache/yum or yum clean all is fine
|
The way to fix DCO is reset to first commit and amend DCO (DCO require -s sgin off in each commits) |
Signed-off-by: Icey <1790571317@qq.com>
wxsIcey
changed the title
wangxiyuan
approved these changes
Apr 27, 2025
| labels: ${{ steps.meta.outputs.labels }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| file: Dockerfile.openEuler | ||
| # TODO: support and enable custom ops build for openEuler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Provide users with openEuler-based vllm images for vllm v0.7.3
Does this PR introduce any user-facing change?
None
How was this patch tested?