- 
                Notifications
    You must be signed in to change notification settings 
- Fork 528
[CI] Add accuracy test for Qwen2.5-VL-3B-Instruct #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fc2290    to
    04f5971      
    Compare
  
    2d97020    to
    30a4c65      
    Compare
  
    | let's merge this after CI is refactored. Thanks. | 
089037a    to
    8121193      
    Compare
  
    | 
 done | 
        
          
                tests/long_term/test_accuracy.py
              
                Outdated
          
        
      | # wrap prompts in a chat-style template. | ||
| APPLY_CHAT_TEMPLATE = { | ||
| "Qwen/Qwen2.5-0.5B-Instruct": False, | ||
| "Qwen/Qwen2.5-VL-3B-Instruct": True | ||
| } | ||
| # Few-shot examples handling as multi-turn dialogues. | ||
| FEWSHOT_AS_MULTITURN = { | ||
| "Qwen/Qwen2.5-0.5B-Instruct": False, | ||
| "Qwen/Qwen2.5-VL-3B-Instruct": True | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoudn't these be generate from MODEL_TYPE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
        
          
                tests/long_term/test_accuracy.py
              
                Outdated
          
        
      | if model == "Qwen/Qwen2.5-VL-3B-Instruct" and os.getenv( | ||
| "VLLM_USE_V1") == "1": | ||
| pytest.skip( | ||
| "Qwen2.5-VL-3B-Instruct is not supported when VLLM_USE_V1=1") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a decrator after @pytest.mark.parametrize .
and seems all vllm-vlm should be skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only need skip model Qwen2.5-VL-3B-Instruct where VLLM_USE_V1=1, and it run ok when VLLM_USE_V1=0
8121193    to
    ac70438      
    Compare
  
    | VLLM_WORKER_MULTIPROC_METHOD: spawn | ||
| run: | | ||
| if [[ "${{ matrix.os }}" == "linux-arm64-npu-1" ]]; then | ||
| pytest -sv tests/long_term/test_accuracy.py | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pytest -sv tests/long_term/test_accuracy.py | 
| VLLM_USE_V1: 0 | ||
| run: | | ||
| if [[ "${{ matrix.os }}" == "linux-arm64-npu-1" ]]; then | ||
| pytest -sv tests/long_term/test_accuracy.py | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pytest -sv tests/long_term/test_accuracy.py | 
ac70438    to
    9930c96      
    Compare
  
    | Need trigger long term test after main CI fixed: #905 | 
| This pull request has conflicts, please resolve those before we can evaluate the pull request. | 
9930c96    to
    13bd8d3      
    Compare
  
    Signed-off-by: hfadzxy <starmoon_zhang@163.com>
13bd8d3    to
    064f779      
    Compare
  
    ### What this PR does / why we need it? Add accuracy test for Qwen2.5-VL-3B-Instruct Signed-off-by: hfadzxy <starmoon_zhang@163.com>
### What this PR does / why we need it? Add accuracy test for Qwen2.5-VL-3B-Instruct Signed-off-by: hfadzxy <starmoon_zhang@163.com>
What this PR does / why we need it?
Add accuracy test for Qwen2.5-VL-3B-Instruct
Does this PR introduce any user-facing change?
How was this patch tested?