Skip to content

Conversation

@zhangxinyuehfad
Copy link
Contributor

What this PR does / why we need it?

Add accuracy test for Qwen2.5-VL-3B-Instruct

Does this PR introduce any user-facing change?

How was this patch tested?

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_accuracy_ci branch 6 times, most recently from 4fc2290 to 04f5971 Compare May 9, 2025 14:05
@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_accuracy_ci branch 4 times, most recently from 2d97020 to 30a4c65 Compare May 22, 2025 07:59
@wangxiyuan
Copy link
Collaborator

let's merge this after CI is refactored. Thanks.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_accuracy_ci branch 7 times, most recently from 089037a to 8121193 Compare June 3, 2025 01:37
@zhangxinyuehfad
Copy link
Contributor Author

let's merge this after CI is refactored. Thanks.

done

Comment on lines 61 to 70
# wrap prompts in a chat-style template.
APPLY_CHAT_TEMPLATE = {
"Qwen/Qwen2.5-0.5B-Instruct": False,
"Qwen/Qwen2.5-VL-3B-Instruct": True
}
# Few-shot examples handling as multi-turn dialogues.
FEWSHOT_AS_MULTITURN = {
"Qwen/Qwen2.5-0.5B-Instruct": False,
"Qwen/Qwen2.5-VL-3B-Instruct": True
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudn't these be generate from MODEL_TYPE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 102 to 98
if model == "Qwen/Qwen2.5-VL-3B-Instruct" and os.getenv(
"VLLM_USE_V1") == "1":
pytest.skip(
"Qwen2.5-VL-3B-Instruct is not supported when VLLM_USE_V1=1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a decrator after @pytest.mark.parametrize .

and seems all vllm-vlm should be skipped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only need skip model Qwen2.5-VL-3B-Instruct where VLLM_USE_V1=1, and it run ok when VLLM_USE_V1=0

VLLM_WORKER_MULTIPROC_METHOD: spawn
run: |
if [[ "${{ matrix.os }}" == "linux-arm64-npu-1" ]]; then
pytest -sv tests/long_term/test_accuracy.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytest -sv tests/long_term/test_accuracy.py

VLLM_USE_V1: 0
run: |
if [[ "${{ matrix.os }}" == "linux-arm64-npu-1" ]]; then
pytest -sv tests/long_term/test_accuracy.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytest -sv tests/long_term/test_accuracy.py

@Yikun Yikun added long-term-test enable long term test for PR ready-for-test start test by label for PR and removed long-term-test enable long term test for PR ready-for-test start test by label for PR labels Jun 4, 2025
@Yikun
Copy link
Collaborator

Yikun commented Jun 4, 2025

Need trigger long term test after main CI fixed: #905

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Yikun Yikun added long-term-test enable long term test for PR ready-for-test start test by label for PR and removed ready-for-test start test by label for PR labels Jun 4, 2025
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
@wangxiyuan wangxiyuan merged commit 7737aaa into vllm-project:main Jun 5, 2025
14 checks passed
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
### What this PR does / why we need it?
Add accuracy test for Qwen2.5-VL-3B-Instruct


Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Add accuracy test for Qwen2.5-VL-3B-Instruct


Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

long-term-test enable long term test for PR module:tests ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants