Skip to content

Conversation

@celestialli
Copy link
Contributor

@celestialli celestialli commented May 7, 2025

What this PR does / why we need it?

This is a continuing work of #716.
This PR add workflow to build and release wheel, and also release source to PYPI.
We have 3 conditions to trigger the workflow:

  1. PR to main and *-dev
  2. push to main and *-dev
  3. push tag with name of v*

Release to PYPI will only be done under condition 3. Under condition 1 and 2, it will generate .tar.gz and build .whl, upload to github artifacts but will not release.

update:
Will build .whl and upload to github artifacts with scheduled task.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

All triggered conditions are well tested with my fork repo.

@wangxiyuan
Copy link
Collaborator

wangxiyuan commented May 10, 2025

have you test the twine upload step? I notice that the name of the wheel package is not correct for pep guide. for example, it's vllm_ascend-0.1.dev1+g6a4fc33-cp310-cp310-linux_aarch64.whl. but for pep guide, it should be something like vllm_ascend-0.1.dev1+g6a4fc33-cp310-cp310-manylinux2014_aarch64.whl

https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/#platform-tag

@celestialli
Copy link
Contributor Author

celestialli commented May 12, 2025

have you test the twine upload step? I notice that the name of the wheel package is not correct for pep guide. for example, it's vllm_ascend-0.1.dev1+g6a4fc33-cp310-cp310-linux_aarch64.whl. but for pep guide, it should be something like vllm_ascend-0.1.dev1+g6a4fc33-cp310-cp310-manylinux2014_aarch64.whl

https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/#platform-tag

Well, I have tested with the twine upload but a error happened, mostly because lack of a project on my PYPI account. It is expected to run smoothly if we get the right PYPI_TOKEN and we have the right project on the account, please don't worry.
manylinux tag is there because it is compiled under manylinux image, but as I see, it is not mandatory norms. We can see,
whl filename of sglang is named with sglang-0.4.6.post3-py3-none-any.whl.
https://pypi.org/project/sglang/#files

@wangxiyuan
Copy link
Collaborator

wangxiyuan commented May 12, 2025

you can reigster a pypi account and try twine upload with a test package local. it's quite easy

@celestialli
Copy link
Contributor Author

have you test the twine upload step? I notice that the name of the wheel package is not correct for pep guide. for example, it's vllm_ascend-0.1.dev1+g6a4fc33-cp310-cp310-linux_aarch64.whl. but for pep guide, it should be something like vllm_ascend-0.1.dev1+g6a4fc33-cp310-cp310-manylinux2014_aarch64.whl

https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/#platform-tag

linux_aarch64 suffix will indeed invoke a twine error. It's fixed, thanks. And I have added a scheduled task to build a .whl every day.

@wangxiyuan wangxiyuan added the ready read for review label May 20, 2025
@Yikun
Copy link
Collaborator

Yikun commented May 20, 2025

Thanks for contributions, I will take a look before merge.

Signed-off-by: Shuqiao Li <celestialli@outlook.com>
@wangxiyuan wangxiyuan removed the ready read for review label May 22, 2025
Yikun added 2 commits May 26, 2025 11:27
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun
Copy link
Collaborator

Yikun commented May 26, 2025

image

Just a rename

@Yikun Yikun added the ready read for review label May 26, 2025
@wangxiyuan wangxiyuan merged commit 01e3d59 into vllm-project:main May 26, 2025
15 checks passed
XWFAlone pushed a commit to XWFAlone/vllm-ascend that referenced this pull request May 26, 2025
### What this PR does / why we need it?

This is a continuing work of vllm-project#716.
This PR add workflow to build and release wheel, and also release source
to PYPI.
We have 3 conditions to trigger the workflow:

1. PR to `main` and `*-dev`
2. push to `main` and `*-dev`
3. push tag with name of `v*`

Release to PYPI will only be done under condition 3. Under condition 1
and 2, it will generate .tar.gz and build .whl, upload to github
artifacts but will not release.

update:
Will build .whl and upload to github artifacts with scheduled task.


### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
All triggered conditions are well tested with my fork repo.

---------

Signed-off-by: Shuqiao Li <celestialli@outlook.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Co-authored-by: Yikun Jiang <yikunkero@gmail.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request May 30, 2025
### What this PR does / why we need it?

This is a continuing work of vllm-project#716.
This PR add workflow to build and release wheel, and also release source
to PYPI.
We have 3 conditions to trigger the workflow:

1. PR to `main` and `*-dev`
2. push to `main` and `*-dev`
3. push tag with name of `v*`

Release to PYPI will only be done under condition 3. Under condition 1
and 2, it will generate .tar.gz and build .whl, upload to github
artifacts but will not release.

update:
Will build .whl and upload to github artifacts with scheduled task.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
All triggered conditions are well tested with my fork repo.

---------

Signed-off-by: Shuqiao Li <celestialli@outlook.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Co-authored-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
@Yikun Yikun mentioned this pull request Jun 28, 2025
40 tasks
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
### What this PR does / why we need it?

This is a continuing work of vllm-project#716.
This PR add workflow to build and release wheel, and also release source
to PYPI.
We have 3 conditions to trigger the workflow:

1. PR to `main` and `*-dev`
2. push to `main` and `*-dev`
3. push tag with name of `v*`

Release to PYPI will only be done under condition 3. Under condition 1
and 2, it will generate .tar.gz and build .whl, upload to github
artifacts but will not release.

update:
Will build .whl and upload to github artifacts with scheduled task.


### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
All triggered conditions are well tested with my fork repo.

---------

Signed-off-by: Shuqiao Li <celestialli@outlook.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Co-authored-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?

This is a continuing work of vllm-project#716.
This PR add workflow to build and release wheel, and also release source
to PYPI.
We have 3 conditions to trigger the workflow:

1. PR to `main` and `*-dev`
2. push to `main` and `*-dev`
3. push tag with name of `v*`

Release to PYPI will only be done under condition 3. Under condition 1
and 2, it will generate .tar.gz and build .whl, upload to github
artifacts but will not release.

update:
Will build .whl and upload to github artifacts with scheduled task.


### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
All triggered conditions are well tested with my fork repo.

---------

Signed-off-by: Shuqiao Li <celestialli@outlook.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Co-authored-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants