[Perf] speed up topk_topp_sampler #980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhengWG
changed the title
76 tasks
Collaborator
|
#970 is involved with the change and you have been added as co-author. Close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Under temperature > 0, the sampler logic's processing time increased to 8ms from 3ms for a batch size of 24 per dp rank, with the scatter operation accounting for 6ms. By optimizing the scatter operator with reference to the TPU implementation, we've reduced the total sampler time to 2ms.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested with vllm_ascend, verifying correct behavior in TopKTopPSampler using forward_npu.