Skip to content

Fix DP dummy run cfg #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Fix DP dummy run cfg #284

merged 1 commit into from
Sep 29, 2025

Conversation

@wuxun-zhang
Copy link
Contributor

@wuxun-zhang wuxun-zhang commented Sep 28, 2025

No description provided.

@wuxun-zhang
Fix DP dummy run cfg
eb625f2 
Signed-off-by: Wuxun Zhang <wuxun.zhang@intel.com>
@wuxun-zhang
Copy link
Contributor Author

wuxun-zhang commented Sep 28, 2025

@xuechendi Please take a look, it's related to changes from #157, but not sure why it's not caught by CI.

@github-actions
Copy link

github-actions bot commented Sep 28, 2025

✅ CI Passed

All checks passed successfully against the following vllm commit:
c242c98031b87d00999e07dbb4aa9b2a70798c6c

@wuxun-zhang
Copy link
Contributor Author

wuxun-zhang commented Sep 28, 2025

@xuechendi This PR can fix the issue previously reported.
BTW, I also tested with lastest vllm commit, it breaks our DP functionality again. I prepared another patch for this (#285). Merging this fix separately, or combining with PR#285, what's you preference?

xuechendi
xuechendi approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@xuechendi xuechendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuechendi xuechendi merged commit e48e761 into vllm-project:main Sep 29, 2025
32 checks passed
@xuechendi
Copy link
Collaborator

xuechendi commented Sep 29, 2025

@xuechendi This PR can fix the issue previously reported. BTW, I also tested with lastest vllm commit, it breaks our DP functionality again. I prepared another patch for this (#285). Merging this fix separately, or combining with PR#285, what's you preference?

I've merged this one, please continue with the other one

iboiko-habana pushed a commit to iboiko-habana/vllm-gaudi that referenced this pull request Oct 2, 2025
@wuxun-zhang @iboiko-habana
Fix DP dummy run cfg (vllm-project#284)
d460589 
Signed-off-by: Wuxun Zhang <wuxun.zhang@intel.com>
Signed-off-by: Iryna Boiko <iboiko@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuechendi xuechendi xuechendi approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@mswiniarsk mswiniarsk Awaiting requested review from mswiniarsk mswiniarsk is a code owner

@adobrzyn adobrzyn Awaiting requested review from adobrzyn adobrzyn is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wuxun-zhang @xuechendi