-
Notifications
You must be signed in to change notification settings - Fork 26
[Docs] Migrate from Sphinx to MkDocs #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
d913157 to
09cbe17
Compare
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
| # Configuration | ||
|
|
||
| For a complete list of configuration options, see <project:./env_vars.md>. | ||
| For a complete list of configuration options, see [Environment Variables](env_vars.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this way better!
mkdocs.yaml
Outdated
| theme: | ||
| name: material | ||
| # logo: assets/logos/vllm-logo-only-light.ico | ||
| # favicon: assets/logos/vllm-logo-only-light.ico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still want these 2 commented lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed ✅
prashantgupta24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some questions/nits
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.