Skip to content

Conversation

@joerunde
Copy link
Collaborator

@joerunde joerunde commented Feb 27, 2025

Post v0.7.3 this class was renamed from LoraNotSupportedWorkerBase to LoRANotSupportedWorkerBase. This causes our import of it to fail, so this PR implements a try/catch on the import for backwards compatibility so that this doesn't break on future vllm releases.

See vllm-project/vllm#13831

Tested on a local install with vllm@b382a7f28

Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tdoublep tdoublep self-requested a review March 5, 2025 12:52
Copy link
Member

@tdoublep tdoublep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdoublep
Copy link
Member

tdoublep commented Mar 5, 2025

Looks like the yapf check is failing here

@yannicks1 yannicks1 self-requested a review March 6, 2025 16:51
Copy link
Collaborator

@yannicks1 yannicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yannicks1 yannicks1 merged commit 8ec9c94 into vllm-project:main Mar 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants