-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Closed
Closed
Copy link
Labels
feature requestNew feature or requestNew feature or requeststaleOver 90 days of inactivityOver 90 days of inactivity
Description
🚀 The feature, motivation and pitch
Now P/D is supported in latest release, it would be great to expose metrics like kv_xfer_time, kv_xfer_bytes, kv_xfer_num_blocks etc. to both console and prometheus, for performance monitoring.
I think we can break the work into several parts
- pipe the metrics from
nixl_connectorall the way tomodel_runner, this can be further broken into
a. change interface ofget_finishedto return not only ids, ideally a new class to aggregate all the infomation
b. add metrics to the new class, it's worth discussion wether we want aggregated stats (avg, sum) or raw stats - consume the metrics from logger, in
vllm/v1/metrics/loggers.py - consume the metrics from promethus logger, to be done in
vllm/v1/metrics/loggers.py
Alternatives
No response
Additional context
No response
Before submitting a new issue...
- Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
cc @NickLucche @robertgshaw2-redhat @kouroshHakha @ruisearch42
NickLucche, kouroshHakha, kartikx and JeffLuoo
Metadata
Metadata
Assignees
Labels
feature requestNew feature or requestNew feature or requeststaleOver 90 days of inactivityOver 90 days of inactivity